Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race, don't modify mpost #1745

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Fix race, don't modify mpost #1745

merged 1 commit into from
Nov 8, 2017

Conversation

janardhan1993
Copy link
Contributor

@janardhan1993 janardhan1993 commented Nov 8, 2017

Clear txnMap before drop all so that future deltas won't be written to
disk.

Fix some tests and blocking fix conflicting transactions

update


This change is Reviewable

Clear txnMap before drop all so that future deltas won't be written to
disk.

Fix some tests and blocking fix conflicting transactions

update
@manishrjain
Copy link
Contributor

:lgtm:


Reviewed 15 of 15 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


posting/list.go, line 542 at r1 (raw file):

	midx := 0
	var deleteTs uint64
	if l.markdeleteAll > 0 {

if == 0, else if ..


worker/mutation.go, line 578 at r1 (raw file):

	}
	commitTimestamps := resp.Ts
	x.AssertTruef(len(startTimestamps) == len(commitTimestamps), "%+v %+v\n", startTimestamps, commitTimestamps)

x.AssertTrue.


Comments from Reviewable

@janardhan1993 janardhan1993 merged commit eb5be8b into master Nov 8, 2017
@janardhan1993 janardhan1993 deleted the jan/fix_tests branch November 8, 2017 08:15
mangalaman93 pushed a commit that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants