Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changelog. #142

Merged
merged 2 commits into from
Feb 24, 2020
Merged

Add changelog. #142

merged 2 commits into from
Feb 24, 2020

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Feb 24, 2020 •
edited by manishrjain
Loading

This change is Reviewable

@martinmr martinmr requested a review from danielmai February 24, 2020 20:25
danielmai
danielmai approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes to make, and then :lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jarifibrahim, @karlmcguire, @manishrjain, and @martinmr)

CHANGELOG.md, line 15 at r1 (raw file):

## 0.0.2 - 02-24-2020

Put square brackets around [0.0.2] so it's a Markdown link.

Make the date 2020-02-24 (YEAR-MONTH-DATE), so it's clear.

CHANGELOG.md, line 19 at r1 (raw file):

### Changed

You can remove this section since nothing has changed.

@martinmr martinmr merged commit dbc185e into master Feb 24, 2020
@martinmr martinmr deleted the martinmr/add-changelog branch February 24, 2020 21:59
@jarifibrahim jarifibrahim mentioned this pull request Jun 30, 2020
Merged
jarifibrahim pushed a commit to hypermodeinc/badger that referenced this pull request Jun 30, 2020
Update ristretto to commit f66de99 (#1391)
09dfa66 
The update brings following changes from ristretto into badger

```
f66de99 Improve handling of updated items (hypermodeinc/ristretto#168)
aec7994 Fix flaky TestCacheDel test (hypermodeinc/ristretto#169)
a093fe6 Add benchmark plots to the project repo (hypermodeinc/ristretto#166)
49dc42c Add Anurag as codeowner (hypermodeinc/ristretto#158)
7a3f2d3 z: use MemHashString and xxhash.Sum64String (hypermodeinc/ristretto#153)
9c31bb2 Check conflict key before updating expiration map. (hypermodeinc/ristretto#154)
62cb731 Fix race condition in Cache.Clear (hypermodeinc/ristretto#133)
9af1934 Docs and whitespace changes for readability. (hypermodeinc/ristretto#143)
dbc185e Add changelog. (hypermodeinc/ristretto#142)
ff325ad Remove key from policy after TTL eviction (hypermodeinc/ristretto#130)
2dd5ff5 Use the require library in all the tests. (hypermodeinc/ristretto#128)
7c48141 Use require in all tests in cache_test.go (hypermodeinc/ristretto#127)
51e97ad Sets with TTL (hypermodeinc/ristretto#122)
d3e7c37 Add benchmarks for math.rand and fastrand (hypermodeinc/ristretto#118)
593823e Integrate fixes from PR hypermodeinc/ristretto#91. (hypermodeinc/ristretto#126)
29b4dd7 Fix comments. (hypermodeinc/ristretto#123)
ddf345c Removed workflows directory. (hypermodeinc/ristretto#124)
eb104d0 Add martinmr to CODEOWNERS file. (hypermodeinc/ristretto#125)
```
jarifibrahim pushed a commit to hypermodeinc/badger that referenced this pull request Jul 6, 2020
Update ristretto to commit f66de99 (#1391)
25fd0ef 
The update brings following changes from ristretto into badger

```
f66de99 Improve handling of updated items (hypermodeinc/ristretto#168)
aec7994 Fix flaky TestCacheDel test (hypermodeinc/ristretto#169)
a093fe6 Add benchmark plots to the project repo (hypermodeinc/ristretto#166)
49dc42c Add Anurag as codeowner (hypermodeinc/ristretto#158)
7a3f2d3 z: use MemHashString and xxhash.Sum64String (hypermodeinc/ristretto#153)
9c31bb2 Check conflict key before updating expiration map. (hypermodeinc/ristretto#154)
62cb731 Fix race condition in Cache.Clear (hypermodeinc/ristretto#133)
9af1934 Docs and whitespace changes for readability. (hypermodeinc/ristretto#143)
dbc185e Add changelog. (hypermodeinc/ristretto#142)
ff325ad Remove key from policy after TTL eviction (hypermodeinc/ristretto#130)
2dd5ff5 Use the require library in all the tests. (hypermodeinc/ristretto#128)
7c48141 Use require in all tests in cache_test.go (hypermodeinc/ristretto#127)
51e97ad Sets with TTL (hypermodeinc/ristretto#122)
d3e7c37 Add benchmarks for math.rand and fastrand (hypermodeinc/ristretto#118)
593823e Integrate fixes from PR hypermodeinc/ristretto#91. (hypermodeinc/ristretto#126)
29b4dd7 Fix comments. (hypermodeinc/ristretto#123)
ddf345c Removed workflows directory. (hypermodeinc/ristretto#124)
eb104d0 Add martinmr to CODEOWNERS file. (hypermodeinc/ristretto#125)
```

(cherry picked from commit 09dfa66)
jarifibrahim pushed a commit to hypermodeinc/badger that referenced this pull request Oct 2, 2020
Update ristretto to commit f66de99 (#1391)
0e9748b 
The update brings following changes from ristretto into badger

```
f66de99 Improve handling of updated items (hypermodeinc/ristretto#168)
aec7994 Fix flaky TestCacheDel test (hypermodeinc/ristretto#169)
a093fe6 Add benchmark plots to the project repo (hypermodeinc/ristretto#166)
49dc42c Add Anurag as codeowner (hypermodeinc/ristretto#158)
7a3f2d3 z: use MemHashString and xxhash.Sum64String (hypermodeinc/ristretto#153)
9c31bb2 Check conflict key before updating expiration map. (hypermodeinc/ristretto#154)
62cb731 Fix race condition in Cache.Clear (hypermodeinc/ristretto#133)
9af1934 Docs and whitespace changes for readability. (hypermodeinc/ristretto#143)
dbc185e Add changelog. (hypermodeinc/ristretto#142)
ff325ad Remove key from policy after TTL eviction (hypermodeinc/ristretto#130)
2dd5ff5 Use the require library in all the tests. (hypermodeinc/ristretto#128)
7c48141 Use require in all tests in cache_test.go (hypermodeinc/ristretto#127)
51e97ad Sets with TTL (hypermodeinc/ristretto#122)
d3e7c37 Add benchmarks for math.rand and fastrand (hypermodeinc/ristretto#118)
593823e Integrate fixes from PR hypermodeinc/ristretto#91. (hypermodeinc/ristretto#126)
29b4dd7 Fix comments. (hypermodeinc/ristretto#123)
ddf345c Removed workflows directory. (hypermodeinc/ristretto#124)
eb104d0 Add martinmr to CODEOWNERS file. (hypermodeinc/ristretto#125)
```
manishrjain pushed a commit to outcaste-io/outserv that referenced this pull request Jul 6, 2022
Update ristretto to commit f66de99 (#1391)
cf51ce1 
The update brings following changes from ristretto into badger

```
f66de99 Improve handling of updated items (hypermodeinc/ristretto#168)
aec7994 Fix flaky TestCacheDel test (hypermodeinc/ristretto#169)
a093fe6 Add benchmark plots to the project repo (hypermodeinc/ristretto#166)
49dc42c Add Anurag as codeowner (hypermodeinc/ristretto#158)
7a3f2d3 z: use MemHashString and xxhash.Sum64String (hypermodeinc/ristretto#153)
9c31bb2 Check conflict key before updating expiration map. (hypermodeinc/ristretto#154)
62cb731 Fix race condition in Cache.Clear (hypermodeinc/ristretto#133)
9af1934 Docs and whitespace changes for readability. (hypermodeinc/ristretto#143)
dbc185e Add changelog. (hypermodeinc/ristretto#142)
ff325ad Remove key from policy after TTL eviction (hypermodeinc/ristretto#130)
2dd5ff5 Use the require library in all the tests. (hypermodeinc/ristretto#128)
7c48141 Use require in all tests in cache_test.go (hypermodeinc/ristretto#127)
51e97ad Sets with TTL (hypermodeinc/ristretto#122)
d3e7c37 Add benchmarks for math.rand and fastrand (hypermodeinc/ristretto#118)
593823e Integrate fixes from PR hypermodeinc/ristretto#91. (hypermodeinc/ristretto#126)
29b4dd7 Fix comments. (hypermodeinc/ristretto#123)
ddf345c Removed workflows directory. (hypermodeinc/ristretto#124)
eb104d0 Add martinmr to CODEOWNERS file. (hypermodeinc/ristretto#125)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmai danielmai danielmai approved these changes

@jarifibrahim jarifibrahim Awaiting requested review from jarifibrahim

@karlmcguire karlmcguire Awaiting requested review from karlmcguire

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinmr @danielmai