Feature: README #19
Merged
Feature: README #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. @zenangst you want to review it? |
| URL to your `UIImageView`. | ||
| It does nothing but caching, but it does it well, having everything you expect | ||
| from this kind of library. It offers a good public API with out-of-box | ||
| implementations and great customization possibilities. |
There was a problem hiding this comment.
I would change this paragraph to something like this;
It does nothing but caching, but it does it well. It offers a good public API with out-of-box implementations and great customization possibilities.
| ``` | ||
|
|
||
| ### Strict cache |
There was a problem hiding this comment.
Strict cache sounds so harsh 😿
Should we call it Type safe cache instead? 😁
There was a problem hiding this comment.
@zenangst Type safe cache? Should the other one be unsafe then? 😄
There was a problem hiding this comment.
Well, then I guess no one would use it ^^
But I think the other one makes sense, it's hybrid.
|
Fixes: #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zenangst @RamonGilabert