feat: add Service type to BJJ did

hypersign-protocol · Vishwas1 · Oct 3, 2024 · Dec 28, 2023 · Mar 13, 2024 · Sep 27, 2024
commit 779d609f09a70473678eaffe2d4c53802d2c443c
diff --git a/x/ssi/ld-context/types.go b/x/ssi/ld-context/types.go
@@ -297,6 +297,7 @@ type JsonLdDidDocumentWithoutVM struct {
 	CapabilityInvocation []verificationMethodWithoutController `json:"capabilityInvocation,omitempty"`
 	KeyAgreement         []verificationMethodWithoutController `json:"keyAgreement,omitempty"`
 	Proof                JsonLdDocumentProof                   `json:"proof,omitempty"`
+	Service              []*types.Service                      `protobuf:"bytes,11,rep,name=service,proto3" json:"service,omitempty"`
 }
 
 func (doc *JsonLdDidDocumentWithoutVM) GetContext() []contextObject {
@@ -370,6 +371,7 @@ func NewJsonLdDidDocumentWithoutVM(didDoc *types.DidDocument, docProof *types.Do
 	jsonLdDoc.Proof.Created = docProof.Created
 	jsonLdDoc.Proof.ProofPurpose = docProof.ProofPurpose
 	jsonLdDoc.Proof.VerificationMethod = docProof.VerificationMethod + docProof.ProofPurpose
+	jsonLdDoc.Service = didDoc.Service
 	return jsonLdDoc
 }
 

diff --git a/x/ssi/tests/verification_method_test.go b/x/ssi/tests/verification_method_test.go
@@ -260,7 +260,7 @@ func TestBJJAndEd25519(t *testing.T) {
 
 	var service types.Service
 	service.Id = alice_didDoc.Id + "#ServiceTypeAny"
-	service.Type = "ServiceTypeAny"
+	service.Type = "service"
 	service.ServiceEndpoint = "https://example.com"
 	alice_didDoc.Service = append(alice_didDoc.Service, &service)
 
@@ -310,7 +310,7 @@ func TestEd25519AndBJJ(t *testing.T) {
 	alice_kp.VerificationMethodId = alice_didDoc.VerificationMethod[0].Id
 	var service types.Service
 	service.Id = alice_didDoc.Id + "#ServiceType"
-	service.Type = "ServiceType"
+	service.Type = "service"
 	service.ServiceEndpoint = "https://example.com"
 	alice_didDoc.Service = append(alice_didDoc.Service, &service)
 

diff --git a/x/ssi/ante/decorators.go b/x/ssi/ante/decorators.go

 	err := bankKeeper.SendCoinsFromAccountToModule(ctx, acc.GetAddress(), types.FeeCollectorName, fees)
 	if err != nil {
 		return errors.Wrapf(sdkerrors.ErrInsufficientFunds, err.Error())
 	}

 	return nil
diff --git a/x/ssi/keeper/msg_server_create_credential.go b/x/ssi/keeper/msg_server_create_credential.go
 	issuanceDate := msgCredStatus.GetIssuanceDate()
 	issuanceDateParsed, err := time.Parse(time.RFC3339, issuanceDate)
 	if err != nil {
 		return nil, errors.Wrapf(types.ErrInvalidDate, fmt.Sprintf("invalid issuance date format: %s", issuanceDate))
 	}

 	// Check if the created date before issuance date

 	// Validate Merkle Root Hash
 	if err := verifyCredentialMerkleRootHash(msgCredStatus.GetCredentialMerkleRootHash()); err != nil {
 		return nil, errors.Wrapf(types.ErrInvalidCredentialMerkleRootHash, err.Error())
 	}

 	// Validate Document Proof

	err := bankKeeper.SendCoinsFromAccountToModule(ctx, acc.GetAddress(), types.FeeCollectorName, fees)
	if err != nil {
	return errors.Wrapf(sdkerrors.ErrInsufficientFunds, err.Error())
Check failure on line 208 in x/ssi/ante/decorators.go GitHub Actions / Golang Lint `printf: non-constant format string in call to cosmossdk.io/errors.Wrapf (govet)`
	}

	return nil
	issuanceDate := msgCredStatus.GetIssuanceDate()
	issuanceDateParsed, err := time.Parse(time.RFC3339, issuanceDate)
	if err != nil {
	return nil, errors.Wrapf(types.ErrInvalidDate, fmt.Sprintf("invalid issuance date format: %s", issuanceDate))
Check failure on line 54 in x/ssi/keeper/msg_server_create_credential.go GitHub Actions / Golang Lint `printf: non-constant format string in call to cosmossdk.io/errors.Wrapf (govet)`
	}

	// Check if the created date before issuance date

	// Validate Merkle Root Hash
	if err := verifyCredentialMerkleRootHash(msgCredStatus.GetCredentialMerkleRootHash()); err != nil {
	return nil, errors.Wrapf(types.ErrInvalidCredentialMerkleRootHash, err.Error())
Check failure on line 68 in x/ssi/keeper/msg_server_create_credential.go GitHub Actions / Golang Lint `printf: non-constant format string in call to cosmossdk.io/errors.Wrapf (govet)`
	}

	// Validate Document Proof