-
Notifications
You must be signed in to change notification settings - Fork 8
chore: use filter in entities query for selections as well #201
Conversation
Test Results367 tests +1 367 ✅ +1 9s ⏱️ -1s Results for commit 9eae09e. ± Comparison against base commit 77592de. This pull request removes 31 and adds 17 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
// set up source filter to be used during selections | ||
// filterTree.acceptVisitor(new SourceFilterVisitor(executionContext)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed this commented section
@@ -330,7 +318,7 @@ QueryNode buildAndFilterTree(EntitiesRequest entitiesRequest) { | |||
} | |||
|
|||
Map<AttributeSource, Filter> sourceToAndFilterMap = | |||
new HashMap<>(buildSourceToAndFilterMap(entitiesRequest.getFilter())); | |||
Map.copyOf(context.getExpressionContext().getSourceToFilterMap()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
returns an unmodifiable map. The map is being modified on L328
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct. Moved it back to HashMap
No description provided.