-
Notifications
You must be signed in to change notification settings - Fork 8
chore | adding the support pagination in explore #202
Conversation
Test Results367 tests ±0 367 ✅ ±0 9s ⏱️ ±0s Results for commit 04b7d0e. ± Comparison against base commit 961268a. This pull request removes 17 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
gateway-service-impl/src/main/java/org/hypertrace/gateway/service/explore/RequestHandler.java
Outdated
Show resolved
Hide resolved
gateway-service-api/src/main/proto/org/hypertrace/gateway/service/v1/explore.proto
Outdated
Show resolved
Hide resolved
gateway-service-impl/src/main/java/org/hypertrace/gateway/service/explore/RequestHandler.java
Outdated
Show resolved
Hide resolved
gateway-service-impl/src/main/java/org/hypertrace/gateway/service/explore/RequestHandler.java
Outdated
Show resolved
Hide resolved
...e-impl/src/main/java/org/hypertrace/gateway/service/explore/entity/EntityRequestHandler.java
Show resolved
Hide resolved
.../src/main/java/org/hypertrace/gateway/service/explore/entity/EntityServiceEntityFetcher.java
Outdated
Show resolved
Hide resolved
gateway-service-api/src/main/proto/org/hypertrace/gateway/service/v1/explore.proto
Outdated
Show resolved
Hide resolved
…vice into aman/explore_page
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
============================================
- Coverage 81.11% 80.87% -0.25%
+ Complexity 1372 1369 -3
============================================
Files 126 126
Lines 6254 6258 +4
Branches 525 521 -4
============================================
- Hits 5073 5061 -12
- Misses 920 938 +18
+ Partials 261 259 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
.../src/main/java/org/hypertrace/gateway/service/explore/entity/EntityServiceEntityFetcher.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @aman-bansal you mentioned that you will try out these changes manually first, and then we can merge this PR. Please let me know if that testing is completed.
@@ -67,7 +59,8 @@ public ExploreResponse.Builder handleRequest( | |||
ExploreResponse.Builder builder = ExploreResponse.newBuilder(); | |||
Set<String> entityIds = new HashSet<>(); | |||
Optional<EntityOption> maybeEntityOption = getEntityOption(exploreRequest); | |||
if (requestOnLiveEntities(maybeEntityOption)) { | |||
boolean requestOnLiveEntities = requestOnLiveEntities(maybeEntityOption); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boolean requestOnLiveEntities = requestOnLiveEntities(maybeEntityOption); | |
boolean canRequestLiveEntities = canRequestLiveEntities(maybeEntityOption); |
No description provided.