Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

chore | adding the support pagination in explore #202

Merged
merged 11 commits into from
Jun 18, 2024
Merged

Conversation

aman-bansal
Copy link
Member

No description provided.

@aman-bansal aman-bansal requested a review from a team as a code owner June 6, 2024 05:36
Copy link

github-actions bot commented Jun 6, 2024

Test Results

367 tests  ±0   367 ✅ ±0   9s ⏱️ ±0s
 68 suites ±0     0 💤 ±0 
 68 files   ±0     0 ❌ ±0 

Results for commit 04b7d0e. ± Comparison against base commit 961268a.

This pull request removes 17 and adds 2 tests. Note that renamed tests count towards both.

      long: 60
      string: "PT1M"
      valueType: LONG
      valueType: STRING
    alias: "numCalls"
    columnName: "SERVICE.numCalls"
    value {
    }
  columnIdentifier {
…
org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [1] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: STRING
      string: "PT1M"
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [2] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: LONG
      long: 60
    }
  }
}
alias: "numCalls"

♻️ This comment has been updated with latest results.

@aman-bansal aman-bansal changed the title chore | adding the support for total and pagination in explore chore | adding the support pagination in explore Jun 7, 2024
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes missing coverage. Please review.

Project coverage is 80.87%. Comparing base (77592de) to head (90c9295).
Report is 2 commits behind head on main.

Current head 90c9295 differs from pull request most recent head 04b7d0e

Please upload reports for the commit 04b7d0e to get more accurate results.

Files Patch % Lines
...rters/EntityServiceAndGatewayServiceConverter.java 0.00% 5 Missing ⚠️
...ice/explore/entity/EntityServiceEntityFetcher.java 70.00% 3 Missing ⚠️
...y/service/explore/entity/EntityRequestHandler.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #202      +/-   ##
============================================
- Coverage     81.11%   80.87%   -0.25%     
+ Complexity     1372     1369       -3     
============================================
  Files           126      126              
  Lines          6254     6258       +4     
  Branches        525      521       -4     
============================================
- Hits           5073     5061      -12     
- Misses          920      938      +18     
+ Partials        261      259       -2     
Flag Coverage Δ
unit 80.87% <47.36%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@saxenakshitiz saxenakshitiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @aman-bansal you mentioned that you will try out these changes manually first, and then we can merge this PR. Please let me know if that testing is completed.

saxenakshitiz
saxenakshitiz previously approved these changes Jun 17, 2024
@@ -67,7 +59,8 @@ public ExploreResponse.Builder handleRequest(
ExploreResponse.Builder builder = ExploreResponse.newBuilder();
Set<String> entityIds = new HashSet<>();
Optional<EntityOption> maybeEntityOption = getEntityOption(exploreRequest);
if (requestOnLiveEntities(maybeEntityOption)) {
boolean requestOnLiveEntities = requestOnLiveEntities(maybeEntityOption);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
boolean requestOnLiveEntities = requestOnLiveEntities(maybeEntityOption);
boolean canRequestLiveEntities = canRequestLiveEntities(maybeEntityOption);

@aman-bansal aman-bansal merged commit 99ef811 into main Jun 18, 2024
7 checks passed
@aman-bansal aman-bansal deleted the aman/explore_page branch June 18, 2024 07:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants