Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: repo-header-labels mimick gitee #950

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

wangyantong2000
Copy link
Collaborator

@wangyantong2000 wangyantong2000 commented Feb 16, 2025

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues (all available keywords):

Details

There are differences between Gitee platform page elements and Github platform page elements, and migration will involve the re adaptation and development of some components. The goal is to reuse existing components as much as possible and conduct secondary development when needed.
This time, I am migrating a feature named repo-header-labels. The migration of subsequent functions can be developed based on the example of this function.

iShot_2025-02-16_14.52.55.mp4

Checklist

Others

@wangyantong2000
Copy link
Collaborator Author

One question is whether the Gitee platform, like the GitHub platform, has a modification option for the brightness mode of platform pages. I only saw the brightness mode of the code in the settings of the Gitee platform, and did not see the brightness mode of the platform page.
@frank-zsy

@wangyantong2000
Copy link
Collaborator Author

If you have time, you can help this pr with testing and code review.@Xsy41

@Xsy41
Copy link
Collaborator

Xsy41 commented Feb 18, 2025

If you have time, you can help this pr with testing and code review.@Xsy41

Ok, I will test and code review as soon as possible.

@frank-zsy
Copy link
Contributor

One question is whether the Gitee platform, like the GitHub platform, has a modification option for the brightness mode of platform pages. I only saw the brightness mode of the code in the settings of the Gitee platform, and did not see the brightness mode of the platform page. @frank-zsy

I do not find the dark mode on Gitee platform either, so I think HyperCRX only need to adapt the light mode for Gitee platform.

@wangyantong2000
Copy link
Collaborator Author

One question is whether the Gitee platform, like the GitHub platform, has a modification option for the brightness mode of platform pages. I only saw the brightness mode of the code in the settings of the Gitee platform, and did not see the brightness mode of the platform page. @frank-zsy

I do not find the dark mode on Gitee platform either, so I think HyperCRX only need to adapt the light mode for Gitee platform.

OK

import ActivityView from './activityView';
import OpenrankView from './openrankView';
import ParticipantView from './participantView';
import { NativePopover } from '../../components/NativePopover';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete this line.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Xsy41
Copy link
Collaborator

Xsy41 commented Feb 19, 2025

Additionally, we can adjust the font color to better match the Gitee theme color #40485B.(although the current font color is also acceptable).The font color in the image above is #40485B, while the image below has not been modified.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants