-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tar bin/helm-s3 Not found in archive #466
Merged
hypnoglow
merged 3 commits into
hypnoglow:master
from
arahmangulov:fix/windows-installation
Jan 31, 2025
Merged
fix: tar bin/helm-s3 Not found in archive #466
hypnoglow
merged 3 commits into
hypnoglow:master
from
arahmangulov:fix/windows-installation
Jan 31, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f12a5ee
to
4209d9d
Compare
Thank you! |
balintzs
reviewed
Jan 31, 2025
esac | ||
os=$(uname -s) | ||
binary_extension="" | ||
case "$(os)" in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect variable reference. Should be ${os}
instead of $(os)
.
Same below.
This change broke the plugin:
|
Facing the same issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind fix
What this PR does / why we need it:
This PR fixes
helm-s3
plugin installation on Windows (CYGWIN, MINGW, MSYS_NT) platforms.Can be reproduced via installing any version above
v0.14.0
, example:This issue started happening after chaning the way of extracting the binary from the tarball: e9e5382#diff-3bac97673cfc352e120c81f8812245c509aa6dfe24f5eeeb07162159fe82aef5L99
While
mv
command is good with moving binary without explicit extension definition, thetar
is pretty restrictive on this, so it's failing on the extraction stage. So, I just addedbinary_extension
variable which would be empty for UNIX/Linux systems, and.exe
suffix will be appended for Windows installations.Also this MR fixes
os
variable usage, the previousinitOS
function hados
definition withuname -s
value and there are unecessary plainuname
calls happening later on.Fixed <4-spaces indentations as well.
Which issue(s) this PR fixes:
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?: