Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the OS Variable on initOS #487

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

salehparsa
Copy link

@salehparsa salehparsa commented Jan 31, 2025

The initOS introduced variable OS but it was not working because of the fact that we haven't used${os}and we used $(os)

It caused the installation breaks and doesn't work at all:

./hack/install.sh: line 37: os: not found
./hack/install.sh: line 42: os: not found
OS '' not supported!

The propose of this Pull Request is to have a quick fix for this issue

@jonathan-busuttil
Copy link

Please look to merge this as it is breaking our pipeline

@jonathan-busuttil
Copy link

@arahmangulov please look at this

@miagao
Copy link

miagao commented Jan 31, 2025

@hypnoglow ^^

@miagao
Copy link

miagao commented Jan 31, 2025

Please look to merge this as it is breaking our pipeline

+1

@salehparsa salehparsa mentioned this pull request Jan 31, 2025
@lrascao
Copy link

lrascao commented Jan 31, 2025

👍🏻

@okanaiki
Copy link

okanaiki commented Jan 31, 2025

Please look to merge this as it is breaking our pipeline

yep helm plugin install https://github.com/hypnoglow/helm-s3.git --version 0.16.0 solves. issue @jonathan-busuttil

@adiospeds
Copy link

anyone got maintainer's phone number .. all our pipelines are failing to :)
image

@lrascao
Copy link

lrascao commented Jan 31, 2025

    - name: Setup helmfile
      uses: mamezou-tech/[email protected]
      with:
        helm-s3-plugin-version: "v0.16.2"

if you're coming from setup-helmfile this pins it to v0.16.2

@hypnoglow hypnoglow enabled auto-merge February 2, 2025 15:27
@hypnoglow hypnoglow merged commit c7ad077 into hypnoglow:master Feb 2, 2025
9 checks passed
@salehparsa salehparsa deleted the fixed-variable branch February 3, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants