add ability to set the Content-Type for the uploaded chart. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that the shell implementation of the integration tests are "legacy", so I ported the same tests to test_push.go. |
bashims
force-pushed
the
add-content-type-arg
branch
from
d0d1ef9 to
611a2a6
Compare
- set the default Charts content-type to application/x-gzip
bashims
force-pushed
the
add-content-type-arg
branch
from
4746232 to
26c9df8
Compare
|
Hi @kylehodgetts I added the default content-type. Can you take another crack at the review? Thanks, -ben |
|
Hey. It looks good to me but I'm just a user :) The maintainer of the repo @hypnoglow will need to okay this. |
|
Hi @hypnoglow , Would you be able to take a look at his PR, we'd like to start using in your deployment pipeline. Thanks, -ben |
hypnoglow
reviewed
Nov 6, 2018
|
Awesome, thanks @bashims! Please check the comment about default content type. Everything else looks good. |
|
Thanks again @bashims |
|
No problem. Thanks for getting this released so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#59 Add ability to optionally specify the Content-Type for the uploaded chart.