Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump karma from 5.2.3 to 6.0.0 #2892

Closed
wants to merge 1 commit into from
Closed

Bump karma from 5.2.3 to 6.0.0 #2892

wants to merge 1 commit into from

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps karma from 5.2.3 to 6.0.0.

Release notes

Sourced from karma's releases.

v6.0.0

6.0.0 (2021-01-13)

Bug Fixes

Features

  • cli: error out on unexpected options or parameters (#3589) (603bbc0)
  • client: update banner with connection, test status, ping times (#3611) (4bf90f7)
  • server: print stack of unhandledrejections (#3593) (35a5842)
  • server: remove deprecated static methods (#3595) (1a65bf1)
  • remove support for running dart code in the browser (#3592) (7a3bd55)

BREAKING CHANGES

  • server: Deprecated require('karma').server.start() and require('karma').Server.start() variants were removed from the public API. Instead use canonical form:
const { Server } = require('karma');
const server = new Server();
server.start();
  • cli: Karma is more strict and will error out if unknown option or argument is passed to CLI.
  • Using Karma to run Dart code in the browser is no longer supported. Use your favorite Dart-to-JS compiler instead.

dart file type has been removed without a replacement.

customFileHandlers DI token has been removed. Use middleware to achieve similar functionality.

customScriptTypes DI token has been removed. It had no effect, so no replacement is provided.

  • deps: Some projects have socket.io tests that are version sensitive.
Changelog

Sourced from karma's changelog.

6.0.0 (2021-01-13)

Bug Fixes

Features

  • cli: error out on unexpected options or parameters (#3589) (603bbc0)
  • client: update banner with connection, test status, ping times (#3611) (4bf90f7)
  • server: print stack of unhandledrejections (#3593) (35a5842)
  • server: remove deprecated static methods (#3595) (1a65bf1)
  • remove support for running dart code in the browser (#3592) (7a3bd55)

BREAKING CHANGES

  • server: Deprecated require('karma').server.start() and require('karma').Server.start() variants were removed from the public API. Instead use canonical form:
const { Server } = require('karma');
const server = new Server();
server.start();
  • cli: Karma is more strict and will error out if unknown option or argument is passed to CLI.
  • Using Karma to run Dart code in the browser is no longer supported. Use your favorite Dart-to-JS compiler instead.

dart file type has been removed without a replacement.

customFileHandlers DI token has been removed. Use middleware to achieve similar functionality.

customScriptTypes DI token has been removed. It had no effect, so no replacement is provided.

  • deps: Some projects have socket.io tests that are version sensitive.
Commits
  • 3653caf chore(release): 6.0.0 [skip ci]
  • 04a811d fix(ci): abandon browserstack tests for Safari and IE (#3615)
  • 4bf90f7 feat(client): update banner with connection, test status, ping times (#3611)
  • 68c4a3a chore(test): run client tests without grunt wrapper (#3604)
  • fec972f fix(middleware): catch errors when loading a module (#3605)
  • 3fca456 fix(server): clean up close-server logic (#3607)
  • 1c9c2de fix(test): mark all second connections reconnects (#3598)
  • 87f7e5e chore(license): Update copyright notice to 2020 [ci skip] (#3568)
  • e6b045f chore(deps): npm audit fix the package-lock.json (#3603)
  • 3c649fa chore(build): remove obsolete Grunt tasks (#3602)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Jan 18, 2021
@robertknight
Copy link
Member

I can reproduce the CI failure locally. The symptoms I see match what is described in this recent upstream issue: karma-runner/karma#3621.

The tests failed locally with the following output:

START:
18 01 2021 11:48:27.937:INFO [framework.browserify]: bundle built
18 01 2021 11:48:28.093:INFO [karma-server]: Karma v6.0.0 server started at http://localhost:9876/
18 01 2021 11:48:28.093:INFO [launcher]: Launching browsers ChromeHeadless_Custom with concurrency unlimited
18 01 2021 11:48:28.104:INFO [launcher]: Starting browser ChromeHeadless
18 01 2021 11:48:28.560:INFO [Chrome Headless 88.0.4298.0 (Linux x86_64)]: Connected on socket 5Y1KiAGQQ-fy43SvAAAB with id 89857706
18 01 2021 11:48:34.143:WARN [web-server]: 404: /test-icon
18 01 2021 11:49:00.929:WARN [Chrome Headless 88.0.4298.0 (Linux x86_64)]: Disconnected (0 times) , because no message in 20000 ms.
Chrome Headless 88.0.4298.0 (Linux x86_64) ERROR
  Disconnected , because no message in 20000 ms.
Chrome Headless 88.0.4298.0 (Linux x86_64) ERROR
  Disconnected , because no message in 20000 ms.

Changing the logLevel setting in karma.config.js to config.LOG_DEBUG revealed that the browser was disconnecting at some point and then reconnecting:

19 01 2021 13:25:33.774:DEBUG [Chrome Headless 88.0.4298.0 (Mac OS 11.0.0)]: Disconnected during run, waiting 2000ms for reconnecting.
19 01 2021 13:25:33.774:DEBUG [Chrome Headless 88.0.4298.0 (Mac OS 11.0.0)]: EXECUTING -> EXECUTING_DISCONNECTED
19 01 2021 13:25:34.227:DEBUG [karma-server]: A browser has connected on socket Bib4aIofYNRINETbAAAD
19 01 2021 13:25:34.229:DEBUG [web-server]: upgrade /socket.io/?EIO=4&transport=websocket&sid=drVdJJ3I9A7P5CH8AAAC
19 01 2021 13:25:34.236:DEBUG [Chrome Headless 88.0.4298.0 (Mac OS 11.0.0)]: Lost socket connection, but browser continued to execute. Reconnected on socket Bib4aIofYNRINETbAAAD.
19 01 2021 13:25:34.236:DEBUG [Chrome Headless 88.0.4298.0 (Mac OS 11.0.0)]: EXECUTING_DISCONNECTED -> EXECUTING

A comment on that issue suggested changing the pingTimeout setting to a larger value. I increased it from the default (5000) to 60000. No luck.

Adding the progress reporter to the reporters config in karma.config.js showed that this disconnection happens after all the tests have run.

1 similar comment
@robertknight
Copy link
Member

I can reproduce the CI failure locally. The symptoms I see match what is described in this recent upstream issue: karma-runner/karma#3621.

The tests failed locally with the following output:

START:
18 01 2021 11:48:27.937:INFO [framework.browserify]: bundle built
18 01 2021 11:48:28.093:INFO [karma-server]: Karma v6.0.0 server started at http://localhost:9876/
18 01 2021 11:48:28.093:INFO [launcher]: Launching browsers ChromeHeadless_Custom with concurrency unlimited
18 01 2021 11:48:28.104:INFO [launcher]: Starting browser ChromeHeadless
18 01 2021 11:48:28.560:INFO [Chrome Headless 88.0.4298.0 (Linux x86_64)]: Connected on socket 5Y1KiAGQQ-fy43SvAAAB with id 89857706
18 01 2021 11:48:34.143:WARN [web-server]: 404: /test-icon
18 01 2021 11:49:00.929:WARN [Chrome Headless 88.0.4298.0 (Linux x86_64)]: Disconnected (0 times) , because no message in 20000 ms.
Chrome Headless 88.0.4298.0 (Linux x86_64) ERROR
  Disconnected , because no message in 20000 ms.
Chrome Headless 88.0.4298.0 (Linux x86_64) ERROR
  Disconnected , because no message in 20000 ms.

Changing the logLevel setting in karma.config.js to config.LOG_DEBUG revealed that the browser was disconnecting at some point and then reconnecting:

19 01 2021 13:25:33.774:DEBUG [Chrome Headless 88.0.4298.0 (Mac OS 11.0.0)]: Disconnected during run, waiting 2000ms for reconnecting.
19 01 2021 13:25:33.774:DEBUG [Chrome Headless 88.0.4298.0 (Mac OS 11.0.0)]: EXECUTING -> EXECUTING_DISCONNECTED
19 01 2021 13:25:34.227:DEBUG [karma-server]: A browser has connected on socket Bib4aIofYNRINETbAAAD
19 01 2021 13:25:34.229:DEBUG [web-server]: upgrade /socket.io/?EIO=4&transport=websocket&sid=drVdJJ3I9A7P5CH8AAAC
19 01 2021 13:25:34.236:DEBUG [Chrome Headless 88.0.4298.0 (Mac OS 11.0.0)]: Lost socket connection, but browser continued to execute. Reconnected on socket Bib4aIofYNRINETbAAAD.
19 01 2021 13:25:34.236:DEBUG [Chrome Headless 88.0.4298.0 (Mac OS 11.0.0)]: EXECUTING_DISCONNECTED -> EXECUTING

A comment on that issue suggested changing the pingTimeout setting to a larger value. I increased it from the default (5000) to 60000. No luck.

Adding the progress reporter to the reporters config in karma.config.js showed that this disconnection happens after all the tests have run.

@robertknight robertknight mentioned this pull request Jan 20, 2021
Merged
@robertknight
Copy link
Member

The issue causing tests to fail here is fixed in the next Karma release: karma-runner/karma#3626.

@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@robertknight robertknight deleted the dependabot/npm_and_yarn/karma-6.0.0 branch January 20, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robertknight