Refactor buildSettings internals and add RPCSettings to settings
#4352
+173
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4352 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 225 225
Lines 8580 8585 +5
Branches 2032 2033 +1
=======================================
+ Hits 8507 8512 +5
Misses 73 73
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
lyzadanger
commented
Mar 24, 2022
lyzadanger
commented
Mar 24, 2022
lyzadanger
commented
Mar 24, 2022
lyzadanger
commented
Mar 24, 2022
| * | ||
| * @param {ConfigFromHost} configFromHost | ||
| * @param {Window} window_ | ||
| * @return {import('../../types/config').RPCSettings|null} |
There was a problem hiding this comment.
Oops, minor nit. This was already imported and @typedef-d in this module.
lyzadanger
commented
Mar 24, 2022
lyzadanger
commented
Mar 24, 2022
lyzadanger
commented
Mar 24, 2022
lyzadanger
commented
Mar 24, 2022
lyzadanger
commented
Mar 24, 2022
robertknight
approved these changes
Mar 25, 2022
lyzadanger
force-pushed
the
build-settings
branch
2 times, most recently
from
3394a5f to
e46ece2
Compare
Add a new `RPCSettings` type to retain RPC-related settings in `SidebarSettings`. These are derived from values provided in `ConfigFromHost`. Refactor internals of `buildSettings` to have a less ambiguous flow and retain RPC settings. Part of hypothesis/lms#3647
lyzadanger
force-pushed
the
build-settings
branch
from
e46ece2 to
7a87abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is primarily concerned with refactoring the internal logic in
build-settingsmodule to be less ambiguous and more amenable to extension. The only outward-facing changes is that some information pertaining to making RPC requests is now retained on a newRPCSettingsobject that is part ofSidebarSettings. We will need to "persist" information about which frame and origin to make RPC requests at (in settings) to be able to communicate about annotation activity to the LMS app to support improved Canvas grading submissions.Part of hypothesis/lms#3647
Depends on #4351 (that one's ready to go, just held up by GitHub outages today, will deploy in the morning)