Export usePopoverShouldClose from entry point #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
commented
Jul 23, 2024
| @@ -20,7 +20,7 @@ export type UsePopoverShouldCloseOptions = { | |||
| * @param handleClose - Callback invoked to close the popover | |||
| * @param options | |||
| */ | |||
| export default function usePopoverShouldClose( | |||
| export function usePopoverShouldClose( | |||
There was a problem hiding this comment.
I switched to a non-default export for consistency with other hooks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1630 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 62 62
Lines 1071 1071
Branches 409 409
=======================================
Hits 1070 1070
Misses 1 1 ☔ View full report in Codecov by Sentry. |
robertknight
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After pointing out in #1629 (review) the fact that I forgot to expose
usePopoverShouldClosefrom the library's entry point, I ended up forgetting to update that PR before merging it.This PR adds what was missing there.