Skip to content

Commit

Permalink
Linting fixes after pylint upgrade
Browse files Browse the repository at this point in the history
  • Loading branch information
marcospri committed Jun 7, 2024
1 parent e1b89c8 commit a08877c
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .cookiecutter/includes/pylint/disables
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Lots of false positives
"no-value-for-parameter",

3 changes: 3 additions & 0 deletions .cookiecutter/includes/tests/pylint/disables
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Lots of false positives
"no-value-for-parameter",

4 changes: 4 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,10 @@ disable = [

# Issues to disable this for false positives, disabling it globally in the meantime https://github.com/PyCQA/pylint/issues/214
"duplicate-code",

# Lots of false positives
"no-value-for-parameter",

]

good-names = [
Expand Down
4 changes: 4 additions & 0 deletions tests/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ disable = [

# Issues to disable this for false positives, disabling it globally in the meantime https://github.com/PyCQA/pylint/issues/214
"duplicate-code",

# Lots of false positives
"no-value-for-parameter",

]

# Just disable PyLint's name style checking for the tests, because we
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ def test_it_complains_with_incorrect_size(self):
def test_it_matches_maximum_size(self):
matcher = HostClass.of_size(at_most=2)

# pylint:disable=use-implicit-booleaness-not-comparison
assert matcher == []
assert matcher == [1, 2]
assert matcher != [1, 2, 3]
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ class TestTypeMixin:
def test_it_matches_specific_class(self):
matcher = HostClass.of_type(list)

# pylint:disable=use-implicit-booleaness-not-comparison
assert matcher == []
assert [] == matcher
assert matcher != set()
Expand Down

0 comments on commit a08877c

Please sign in to comment.