Fix only first page being loaded in PaginatedMultiSelect (#6978)

hypothesis · Jan 31, 2025 · fdd56e9 · fdd56e9
1 parent 9070281
commit fdd56e9
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/lms/static/scripts/frontend_apps/components/dashboard/PaginatedMultiSelect.tsx b/lms/static/scripts/frontend_apps/components/dashboard/PaginatedMultiSelect.tsx
@@ -100,7 +100,7 @@ export default function PaginatedMultiSelect<TResult, TSelect>({
       containerClasses="!w-auto min-w-44"
       buttonContent={buttonContent}
       data-testid={`${entity}-select`}
-      onListboxScroll={e => {
+      onPopoverScroll={e => {
         const element = e.target as HTMLUListElement;
         const newScrollPosition = element.scrollTop;
         const isScrollingDown =

diff --git a/lms/static/scripts/frontend_apps/components/dashboard/test/PaginatedMultiSelect-test.js b/lms/static/scripts/frontend_apps/components/dashboard/test/PaginatedMultiSelect-test.js
@@ -76,7 +76,7 @@ describe('PaginatedMultiSelect', () => {
     }
 
     function scrollTo(select, { scrollHeight, scrollTop = 100 }) {
-      select.props().onListboxScroll({
+      select.props().onPopoverScroll({
         target: {
           clientHeight: 50,
           scrollTop,

diff --git a/package.json b/package.json
@@ -26,7 +26,7 @@
     "@babel/preset-react": "^7.25.9",
     "@babel/preset-typescript": "^7.26.0",
     "@hypothesis/frontend-build": "^3.0.0",
-    "@hypothesis/frontend-shared": "^8.12.0",
+    "@hypothesis/frontend-shared": "^8.16.1",
     "@rollup/plugin-babel": "^6.0.4",
     "@rollup/plugin-commonjs": "^28.0.1",
     "@rollup/plugin-node-resolve": "^15.3.0",

diff --git a/yarn.lock b/yarn.lock
@@ -1996,15 +1996,15 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@hypothesis/frontend-shared@npm:^8.12.0":
-  version: 8.12.0
-  resolution: "@hypothesis/frontend-shared@npm:8.12.0"
+"@hypothesis/frontend-shared@npm:^8.16.1":
+  version: 8.16.1
+  resolution: "@hypothesis/frontend-shared@npm:8.16.1"
   dependencies:
     highlight.js: ^11.6.0
     wouter-preact: ^3.0.0
   peerDependencies:
     preact: ^10.25.1
-  checksum: 900be36b83fa0b73f1705ac6b774414b0ca8a6c779d0e3d96390212c2cb317071d5d8bbf1c771b11ff9e1e040c89972e8a716c3f5d0a0188b5ef6943eaab3c37
+  checksum: 9c1037d4e8f10ad8423e244a75d1f5c1000433b0f519fc87c43dff51cf570d6dc702838dc188cd63c5a3f7a821e0d95ef2114eb2788fded2d30813a915228628
   languageName: node
   linkType: hard
 
@@ -7297,7 +7297,7 @@ __metadata:
     "@babel/preset-react": ^7.25.9
     "@babel/preset-typescript": ^7.26.0
     "@hypothesis/frontend-build": ^3.0.0
-    "@hypothesis/frontend-shared": ^8.12.0
+    "@hypothesis/frontend-shared": ^8.16.1
     "@hypothesis/frontend-testing": ^1.3.1
     "@rollup/plugin-babel": ^6.0.4
     "@rollup/plugin-commonjs": ^28.0.1