Add teacher details directly to the users table #5303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-betts
commented
Apr 18, 2023
|
|
||
| REFRESH MATERIALIZED VIEW report.users; | ||
|
|
||
| ANALYSE report.users; | ||
|
|
||
| -- A unique index is mandatory for concurrent updates used in the refresh | ||
| CREATE UNIQUE INDEX users_id_idx ON report.users (id); | ||
| CREATE INDEX users_registered_date_idx ON report.users USING BRIN (registered_date); |
There was a problem hiding this comment.
I don't think we used this
jon-betts
force-pushed
the
teacher-details
branch
from
466933e to
ab4154e
Compare
jon-betts
force-pushed
the
teacher-details
branch
from
ab4154e to
fd55e02
Compare
marcospri
approved these changes
Apr 18, 2023
| FROM h.user AS users | ||
| WHERE | ||
| users.authority = '{{ region.authority }}' | ||
| -- users.authority = 'lms.hypothes.is' |
There was a problem hiding this comment.
I've left these in permanently as they are kind of handy when copy pasting things into Metabase to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For:
We now know we don't have to keep teacher emails in Canada. This should help us quite a bit making this fast and making full use of Metabase.
This keeps a backward compatible view for
users_sensitivewhile it gets stripped out.