Do not allow YouTube video URLs when using the URLPicker #5503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are currently using raw YouTube video URLs for video assignments, there's a possibility that someone configures it using the regular
URLPicker
instead of theYouTubePicker
.This is problematic, as the latter performs some extra validation that is not performed by the
URLPicker
(is a public existing video, it's not age-restricted, it's embeddable, etc).Bypassing these validations could result in an assignment which fails for students at a later point in time.
This PRs adds a simple check that displays an error if a YouTube video URL is set in the
URLPicker
. The message is different if youtube is not allowed for the active course.YouTube enabled:
YouTube not enabled:
Considerations / TODO
URLPicker
#5499, but this seems like the simplest way to "get away with it" for now.This PR closes #5499