Expose course rosters on the dashboard #6925
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
force-pushed
the
course-rosters
branch
from
8cc6281 to
72e23fa
Compare
Although we don't expose a list of students with metrics for a full course we do list students of a course on the dropdowns. This commit uses the roster data for the dropdown when the feature flag is enabled and the data is aviailable.
marcospri
force-pushed
the
course-rosters
branch
from
72e23fa to
c8d2b81
Compare
marcospri
commented
Jan 13, 2025
| @@ -210,7 +211,40 @@ def get_assignment_roster( | |||
| assignment_id=assignment.id, | |||
| h_userids=h_userids, | |||
| # For launch data we always add the "active" column as true for compatibility with the roster query. | |||
| ).add_columns(True) | |||
| ).add_columns(true()) | |||
There was a problem hiding this comment.
true() is the right type for this.
| .join(LTIRole) | ||
| .where( | ||
| CourseRoster.lms_course_id == lms_course.id, | ||
| CourseRoster.active.is_(True), |
There was a problem hiding this comment.
We now return all rows, not only active ones
lms/services/roster.py
Outdated
| @@ -46,34 +46,45 @@ def get_course_roster( | |||
| lms_course: LMSCourse, | |||
| role_scope: RoleScope | None = None, | |||
| role_type: RoleType | None = None, | |||
| ) -> Select[tuple[LMSUser]]: | |||
| h_userids: list[str] | None = None, | |||
| ) -> Select[tuple[LMSUser, bool]]: | |||
There was a problem hiding this comment.
We return a tuple of (LMSUser, active)
acelaya
approved these changes
Jan 14, 2025
Segment rosters are used a bit differently than assignments ones. We allow filtering by multiple rosters and we'll display a list of those students with the metrics. For assignments we only allow to select one assignment at the time. This adds a bit of extra complexity as we need to query the roster as a combination of rosters
marcospri
force-pushed
the
course-rosters
branch
from
67a9e6f to
4541d98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we don't expose a list of students with metrics for a full course we do list students of a course on the dropdowns.
This commit uses the roster data for the dropdown when the feature flag is enabled and the data is available.
Testing
http://localhost:8001/admin/instances/102/settings
https://hypothesis.instructure.com/courses/319/assignments/3308
make shellOpen the dashboard for the assignment
Navigate un level up, to the course, open the student drop down. It includes all students in the course, not only the ones that have launched.