Add denomalized name columns to join tables #211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For:
Needed for testing:
Metabase doesn't handle joins which result in duplicated column names. It causes the columns to get confused, like 'name'. Adding these to the join tables is both convenient and works around the issue.
This also adds the organization public id where it makes sense, as we always want that too.
Testing notes
In
h
:make services make devdata tox -e dev --run-command "python bin/run_data_task.py --config-file conf/development-app.ini --task report/create_from_scratch"
In LMS:
make services make devdata tox -e dev --run-command "python bin/run_data_task.py --config-file conf/development.ini --task report/create_from_scratch"
In Report:
make services make devdata tox -e dev --run-command "python bin/run_data_task.py --task report/create_from_scratch --no-python"
And test the refresh in Report:
tox -e dev --run-command "python bin/run_data_task.py --task report/refresh --no-python"