-
-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
safe guard against ill formed index.themes #7211
Conversation
just make it int then lol |
yeah but there are like 100 different hits of where this is casted to uint64_t or is used as uint64_t, the least common place where it wont require +100 line change is here |
https://github.com/search?q=repo%3Ahyprwm%2FHyprland%20getMonitorFromID&type=code i mean, gonna require some nifty effort to ensure it isnt overflowing on other places too its being passed uint_32t and uint64_t all over |
I'd be for the ID refactor in a different MR, and doing it with typedefs.
etc |
dropped those for now, il see if i can refactor the types then in another PR |
or im about to seems i force pushed the wrong commit -_- |
avoid adding ill formed Inherit lines to inherit vector and later scanning them, it wont change anything in practice but makes the inherit theme parsing more in line with what its supposed todo. also check for return values of the various string functions so we dont end up erasing the wrong thing.
now |
if the index.theme is ill formatted it could add invalid entries to inherits and unnecesserly scan them for cursor files, no harm there since its catched later in either "/cursors" not existing or the shape fails to load.