-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change install directory of hyprlock's pam configuration file #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g
I'm a baller, shot caller, I'm an arch linux installer |
@fufexan why is nix unhappy |
Same exact reason as in the original PR. You can't access /etc in the nix build sandbox. And neither should we hardcode /etc anyway. Fedora needs to set up the CMAKE_INSTALL_SYSCONFDIR correctly for it to work. |
Does it work on arch ? Haven't used it in a while. |
I guess you can |
thats why I am in favor of a |
I thought about changing it back to su but figured the code was changed for a reason. And I thought about adding that flag to read me for fedora users at least. So I can add that flag later tonight. |
fuffiee.... I think no distro sets this to etc. We should hardcode it, and you can override it for nix. |
I was just gonna take your idea and potentially make an su fallback. If "hyprlock" fails try with the su parameter. Don't know if that is a good idea though |
I committed that, it works well |
I was having issues getting Hyprlock to work on Fedora. My password was never being authenticated correctly. The root of the problem seemed to be the Password.cpp file on line 34 where "su" was changed to "hyprlock" . However turns out the hyprlock pam configuration file was being installed in the /usr/local/ dir which is not where pam seems to look for conf files.
TLDR: So I changed where hyprlock's pam configuration file is being installed to "/etc/pam.d" in the CMakeLists.txt