Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change install directory of hyprlock's pam configuration file #124

Closed
wants to merge 0 commits into from

Conversation

BranchManager
Copy link
Contributor

I was having issues getting Hyprlock to work on Fedora. My password was never being authenticated correctly. The root of the problem seemed to be the Password.cpp file on line 34 where "su" was changed to "hyprlock" . However turns out the hyprlock pam configuration file was being installed in the /usr/local/ dir which is not where pam seems to look for conf files.

TLDR: So I changed where hyprlock's pam configuration file is being installed to "/etc/pam.d" in the CMakeLists.txt

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g

@vaxerski
Copy link
Member

vaxerski commented Mar 2, 2024

I'm a baller, shot caller, I'm an arch linux installer

@vaxerski
Copy link
Member

vaxerski commented Mar 2, 2024

@fufexan why is nix unhappy

@fufexan
Copy link
Member

fufexan commented Mar 2, 2024

Same exact reason as in the original PR. You can't access /etc in the nix build sandbox. And neither should we hardcode /etc anyway.

Fedora needs to set up the CMAKE_INSTALL_SYSCONFDIR correctly for it to work.

@BranchManager
Copy link
Contributor Author

Does it work on arch ? Haven't used it in a while.

@vaxerski
Copy link
Member

vaxerski commented Mar 2, 2024

I guess you can -DCMAKE_INSTALL_SYSCONFDIR:STRING="/etc/"?

@vaxerski
Copy link
Member

vaxerski commented Mar 2, 2024

thats why I am in favor of a su fallback

@BranchManager
Copy link
Contributor Author

I thought about changing it back to su but figured the code was changed for a reason. And I thought about adding that flag to read me for fedora users at least. So I can add that flag later tonight.

@vaxerski
Copy link
Member

vaxerski commented Mar 3, 2024

fuffiee....

image

I think no distro sets this to etc. We should hardcode it, and you can override it for nix.

@fufexan

@BranchManager
Copy link
Contributor Author

I was just gonna take your idea and potentially make an su fallback. If "hyprlock" fails try with the su parameter. Don't know if that is a good idea though

@vaxerski
Copy link
Member

vaxerski commented Mar 3, 2024

I committed that, it works well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants