-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: introduce animation manager and animation config #631
core: introduce animation manager and animation config #631
Conversation
Pretty much copied from hyprland. BREAKING: - Removed `input-field:dots_fade_time`. Now configured via `animation=inputFieldDots,...` - Removed `input-field:fail_transition`. Now configured via `animation=inputFieldColors,...` - Removed `general:no_fade_in` and `general:no_fade_out`. Now configured globally via `animations:enabled` or via `animation=fadeIn,...` and `animation=fadeOut,...`
do we want to wait until we also land the tree stuff in hyprutils? |
However you prefer, I have the code. |
Don't clamp in updateDots, but setValueAndWarp for clearing
b63e94f
to
d219cdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate reviewing long MRs
anyways looks alright if it works and doesnt have a backdoor lgtm
most of the code is stolen from hyprland anyways
Understandable. I am running this since yesterday and hope some people from the discord will test it as well. |
Works well for me. @alba4k also did not have any problems. |
This PR uses AnimationManager and AnimatedVaraible from hyprutils to implement an animation system.
Simplifies adding and implementing existing animations.
Before adding the animation manager, it made sense to move all the colors to hyprgraphics using the same wrapper (CHyprColor) that hyprland uses.
There is a bit of code that is basically the same as in hyprland:
The config for beziers and animations works the same as in Hyprland. This is the animation tree i came up with:
BREAKING:
input-field:dots_fade_time
. Now configured viaanimation=inputFieldDots,...
input-field:fail_transition
. Now configured viaanimation=inputFieldColors,...
general:no_fade_in
andgeneral:no_fade_out
. Now configuredglobally via
animations:enabled
or viaanimation=fadeIn,...
andanimation=fadeOut,...
NEW:
animations:enabled
Closes #610
Closes #566
Closes #254