Show autentication failReason without additional input #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that 1. The renderer is triggered when the onPasswordCheckTimer callback is fired. Previously you had to give an additional input for the renderer to be triggered and the fail reason to show. 2. The updateDots function now sets dots.currentAmout to 0, when a failID is present. That leads to the draw function to return false and the failReason to be displayed until another input happens.
PaideiaDilemma
added a commit
to PaideiaDilemma/hyprlock
that referenced
this pull request
Mar 1, 2024
Follow up to hyprwm#98 Adds input-field:fade_out_timeout config value, which specifies the amount of milliseconds the placeholder text should be shown for. Return fade.animated from PasswordInputField::draw to make sure the fade out is rendered. Remove the conditional call to render in onKey because it is not needed.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that
Addresses #97
Previous behavior (I pressed a key at the end)
wrong_password_previously.mp4
Behavior introduced here
wrong_password.mp4