Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added overlay color and opacity for chapter component. #269

Merged
merged 2 commits into from
Sep 18, 2016
Merged

Added overlay color and opacity for chapter component. #269

merged 2 commits into from
Sep 18, 2016

Conversation

peiche
Copy link
Contributor

@peiche peiche commented Jun 23, 2015

Regarding issue 268, point 3. (The overlay part, anyway.)

@bearded-avenger
Copy link
Collaborator

Thanks Paul! Gonna sit on this. I really feel themes should be responsible for enhancing the view.

@michaelbeil
Copy link
Contributor

There's much to be considered with a wide userbase when adding more options to ASE core, so ponder on this we shall. We always appreciate your PRs @peiche! Keep 'em coming.

@peiche
Copy link
Contributor Author

peiche commented Jun 29, 2015

So I ended up needing to create a pseudo-element overlay again for the content component. The interesting thing here is that the aesop-content-comp-wrap element's :after pseudo-element is already being used in a clearfix. While it didn't have any negative repercussions in this particular post, I don't think it really serves as a long-term solution, due to potential css conflicts.

@hyunsupul hyunsupul merged commit 9ded691 into hyunsupul:release/1.6.3 Sep 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants