Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/292 requestresponselogger memoria tuning v2 #379

Merged
merged 37 commits into from
Nov 25, 2023

Conversation

mate-biro
Copy link
Contributor

@mate-biro mate-biro commented Jan 18, 2023

Teszt:

  • repeat count: 20
  • testPostStream
  • RandomInputStream: 209715200 byte = 209.7152 Mb

Eredmény:

BaseRestLogger

test start | Nov 24, 2023 5:41:51 PM
test end | Nov 24, 2023 5:46:51 PM

BaseRestLogger_v2

Optimized BaseRestLogger

test start | Nov 24, 2023 5:24:19 PM
test end | Nov 24, 2023 5:25:22 PM

BaseRestLogger_opt_v2

@mate-biro mate-biro requested review from a team as code owners January 18, 2023 09:22
@mate-biro mate-biro linked an issue Jan 18, 2023 that may be closed by this pull request
@sonatype-lift
Copy link

sonatype-lift bot commented Jan 18, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/i-Cell-Mobilsoft-Open-Source/coffee/379.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/i-Cell-Mobilsoft-Open-Source/coffee/379.diff | git apply

Once you're satisfied commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

@cserhatit cserhatit self-requested a review August 15, 2023 17:50
@Balazs-Joo Balazs-Joo self-requested a review September 20, 2023 10:42
Balazs-Joo
Balazs-Joo previously approved these changes Sep 20, 2023
@Balazs-Joo
Copy link
Contributor

Lehet tudni valamit erről a javításról és a párjáról?
#376

@mate-biro
Copy link
Contributor Author

mate-biro commented Sep 20, 2023

Lehet tudni valamit erről a javításról és a párjáról? #376

igen, a közeljövőben tervezek visszatérni a feladatra és befejezni. Még az alábbi feladatok vannak vele:

  • feltétel refakt: ha nincs fent a log spec annotáció, akkor tudjuk, hogy mit jelent
    eredetileg ez volt a szándék, hogyha nincs rajta az annotáció és octet stream, akkor korlátozunk (xml-t meg json-t csak akkor korlátozzunk, ha fent van az annotáció)
  • firstReadCycle flag felülvizsgálás: miért read-el újra a MessageBodyReader
  • felülírt Stream osztályok-ban a logika legyen egységesebb, átláthatóbb
  • logolás logika kiszervezése

@mate-biro mate-biro dismissed stale reviews from Balazs-Joo and bucherarnold via 64b0849 October 15, 2023 17:09
@mate-biro mate-biro self-assigned this Nov 2, 2023
@mate-biro mate-biro marked this pull request as ready for review November 8, 2023 20:32
@mate-biro mate-biro merged commit a592aee into master Nov 25, 2023
@mate-biro mate-biro deleted the bugfix/292-requestresponselogger-memoria-tuning-v2 branch November 25, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RequestResponseLogger memory tuning V2
5 participants