-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reload job status every 5 sec. and show monitoring message #110
Conversation
…en workflow section to fit all buttons in one row.
abc3800
to
0919d7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it with
12.zip which took 13 minutes on my machine and worked as expected.
We need to find the balance between refreshing enough times for the user and not stress the machine with all the polling for like a 100 queued jobs. It also depends on the deployment, it would be nice if the refresh rate could be set with an env var like HADDOCK3WEBAPP_REFRESH_RATE _MS.
994e7d4
to
89fe21b
Compare
@sverhoeven I have refactored code to use env variable |
82ce128
to
1ebe2c7
Compare
refactor: add maxLenght as optional param to DotsLoader component
1ebe2c7
to
df7d90a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it out and works as expected.
Split of #113 for later.
c9cc34f
to
bcbce4b
Compare
bcbce4b
to
63659b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried it out. Last checked on field update every 30s. While the dots (dis)appear every second.
Ok to merge
Please delete the images belonging to this Pull Request as they are no longer useful. Goto versions page of each image, find version called pr-110, click on ... button and select Delete version. |
Reload job status
Closes #72
Changes made:
HADDOCK3WEBAPP_REFRESH_RATE_MS
. The default timeout is 10 sec.Example