Bug 1927535 [wpt PR 48842] - [Permissions Policy] update default for …

…`focus-without-user-activation`, a=testonly Automatic update from web-platform-tests [Permissions Policy] update default for `focus-without-user-activation` According to discussion[1] in webappsec WG and WHATWG, we should set the default of `focus-without-user-activation` permissions policy to `EnableForSelf`. [1]: w3c/webappsec-permissions-policy#273 (comment) Bug: 371112534 Change-Id: I7deb757d0074e1262d07f768e58ea53a99d5faa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5950528 Reviewed-by: Sanket Joshi <[email protected]> Commit-Queue: Siye Liu <[email protected]> Reviewed-by: Ian Clelland <[email protected]> Cr-Commit-Position: refs/heads/main@{#1374868} -- wpt-commits: aed1fc329b27fd8fa0db10a7d2640c45a3454ff4 wpt-pr: 48842
i3roly · Oct 30, 2024 · 4f641ac · 4f641ac
1 parent 8997017
commit 4f641ac
Show file tree

Hide file tree

Showing 12 changed files with 45 additions and 10 deletions.
diff --git a/...web-platform/tests/focus/support/activeelement-after-calling-window-focus-middle.sub.html b/...web-platform/tests/focus/support/activeelement-after-calling-window-focus-middle.sub.html
@@ -2,7 +2,7 @@
 <meta charset="utf-8">
 <title>Focus test middle document</title>
 <h1>Middle</h1><br>
-<iframe src="https://{{hosts[][www]}}:{{ports[https][0]}}/focus/support/activeelement-after-calling-window-focus-inner.html"></iframe>
+<iframe allow="focus-without-user-activation" src="https://{{hosts[][www]}}:{{ports[https][0]}}/focus/support/activeelement-after-calling-window-focus-inner.html"></iframe>
 <script>
 let middlelog = "middlelog:";
 

diff --git a/...orm/tests/focus/support/activeelement-after-calling-window-focus-outer-different.sub.html b/...orm/tests/focus/support/activeelement-after-calling-window-focus-outer-different.sub.html
@@ -1,7 +1,7 @@
 <!doctype html>
 <meta charset="utf-8">
 <title>Focus test outer document</title>
-<iframe src="https://{{hosts[alt][www]}}:{{ports[https][0]}}/focus/support/activeelement-after-calling-window-focus-middle.sub.html"></iframe>
+<iframe allow="focus-without-user-activation" src="https://{{hosts[alt][www]}}:{{ports[https][0]}}/focus/support/activeelement-after-calling-window-focus-middle.sub.html"></iframe>
 <script>
 let outerlog = "outerlog:";
 

diff --git a/...platform/tests/focus/support/activeelement-after-calling-window-focus-outer-same.sub.html b/...platform/tests/focus/support/activeelement-after-calling-window-focus-outer-same.sub.html
@@ -1,7 +1,7 @@
 <!doctype html>
 <meta charset="utf-8">
 <title>Focus test outer document</title>
-<iframe src="https://{{hosts[][www]}}:{{ports[https][0]}}/focus/support/activeelement-after-calling-window-focus-middle.sub.html"></iframe>
+<iframe allow="focus-without-user-activation" src="https://{{hosts[][www]}}:{{ports[https][0]}}/focus/support/activeelement-after-calling-window-focus-middle.sub.html"></iframe>
 <script>
 let outerlog = "outerlog:";
 

diff --git a/...s/support/activeelement-after-focusing-different-site-iframe-outer-contentwindow.sub.html b/...s/support/activeelement-after-focusing-different-site-iframe-outer-contentwindow.sub.html
@@ -26,4 +26,4 @@
     }, 1500);
 }
 </script>
-<iframe src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/activeelement-after-focusing-different-site-iframe-inner-contentwindow.html"></iframe>
+<iframe allow="focus-without-user-activation" src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/activeelement-after-focusing-different-site-iframe-inner-contentwindow.html"></iframe>
diff --git a/...support/iframe-contentwindow-focus-with-different-site-intermediate-frame-middle.sub.html b/...support/iframe-contentwindow-focus-with-different-site-intermediate-frame-middle.sub.html
@@ -1,7 +1,7 @@
 <!doctype html>
 <meta charset="utf-8">
 <title>iframe.contentWindow.focus() with different-site intermediate frame middle</title>
-<iframe src="http://{{hosts[][www]}}:{{ports[http][0]}}/focus/support/iframe-contentwindow-focus-with-different-site-intermediate-frame-inner.html"></iframe>
+<iframe allow="focus-without-user-activation" src="http://{{hosts[][www]}}:{{ports[http][0]}}/focus/support/iframe-contentwindow-focus-with-different-site-intermediate-frame-inner.html"></iframe>
 <script>
 let iframe = document.getElementsByTagName("iframe")[0];
 let log = "";

diff --git a/.../support/iframe-contentwindow-focus-with-different-site-intermediate-frame-outer.sub.html b/.../support/iframe-contentwindow-focus-with-different-site-intermediate-frame-outer.sub.html
@@ -19,4 +19,4 @@
     }, 3000);
 }
 </script>
-<iframe src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/iframe-contentwindow-focus-with-different-site-intermediate-frame-middle.sub.html"></iframe>
+<iframe allow="focus-without-user-activation" src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/iframe-contentwindow-focus-with-different-site-intermediate-frame-middle.sub.html"></iframe>
diff --git a/...us/support/iframe-contentwindow-focus-with-same-as-top-intermediate-frame-middle.sub.html b/...us/support/iframe-contentwindow-focus-with-same-as-top-intermediate-frame-middle.sub.html
@@ -1,7 +1,7 @@
 <!doctype html>
 <meta charset="utf-8">
 <title>iframe.contentWindow.focus() with same-as-top intermediate frame middle</title>
-<iframe src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/iframe-contentwindow-focus-with-same-as-top-intermediate-frame-inner.html"></iframe>
+<iframe allow="focus-without-user-activation" src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/iframe-contentwindow-focus-with-same-as-top-intermediate-frame-inner.html"></iframe>
 <script>
 let iframe = document.getElementsByTagName("iframe")[0];
 let log = "";

diff --git a/...s/focus/support/iframe-contentwindow-focus-with-same-as-top-intermediate-frame-outer.html b/...s/focus/support/iframe-contentwindow-focus-with-same-as-top-intermediate-frame-outer.html
@@ -19,4 +19,4 @@
     }, 2000);
 }
 </script>
-<iframe src="iframe-contentwindow-focus-with-same-as-top-intermediate-frame-middle.sub.html"></iframe>
+<iframe allow="focus-without-user-activation" src="iframe-contentwindow-focus-with-same-as-top-intermediate-frame-middle.sub.html"></iframe>
diff --git a/...rm/tests/focus/support/iframe-focus-with-different-site-intermediate-frame-outer.sub.html b/...rm/tests/focus/support/iframe-focus-with-different-site-intermediate-frame-outer.sub.html
@@ -19,4 +19,4 @@
     }, 3000);
 }
 </script>
-<iframe src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/iframe-focus-with-different-site-intermediate-frame-middle.sub.html"></iframe>
+<iframe allow="focus-without-user-activation" src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/iframe-focus-with-different-site-intermediate-frame-middle.sub.html"></iframe>
diff --git a/testing/web-platform/tests/generic-sensor/generic-sensor-iframe-tests.sub.js b/testing/web-platform/tests/generic-sensor/generic-sensor-iframe-tests.sub.js
@@ -96,7 +96,7 @@ function run_generic_sensor_iframe_tests(sensorData, readingData) {
 
     // Create cross-origin iframe and a sensor inside it.
     const iframe = document.createElement('iframe');
-    iframe.allow = featurePolicies.join(';') + ';';
+    iframe.allow = featurePolicies.join(';') + '; focus-without-user-activation;';
     iframe.src =
         'https://{{domains[www1]}}:{{ports[https][0]}}/generic-sensor/resources/iframe_sensor_handler.html';
     const iframeLoadWatcher = new EventWatcher(t, iframe, 'load');

diff --git a/...eatures/focus-without-user-activation-default-permissions-policy.tentative.https.sub.html b/...eatures/focus-without-user-activation-default-permissions-policy.tentative.https.sub.html
@@ -0,0 +1,24 @@
+<!DOCTYPE html>
+<title>Focus without user activation container policy test</title>
+
+<body>
+  <script src=/resources/testharness.js></script>
+  <script src=/resources/testharnessreport.js></script>
+  <script src=/permissions-policy/resources/permissions-policy.js></script>
+  <script>
+    'use strict';
+    var same_origin_src = '/permissions-policy/experimental-features/resources/permissions-policy-focus-without-user-activation.html';
+    var cross_origin_src = 'https://{{domains[www]}}:{{ports[https][0]}}' +
+      same_origin_src;
+    const header = 'Default "focus-without-user-activation" permissions policy [self]';
+    async_test(t => {
+      test_feature_availability(
+        'focus-without-user-activation', t, same_origin_src, expect_feature_available_default);
+    }, header + " allows same-origin iframes.");
+
+    async_test(t => {
+      test_feature_availability(
+        'focus-without-user-activation', t, cross_origin_src, expect_feature_unavailable_default);
+    }, header + " doesn't allow cross-origin iframes.");
+  </script>
+</body>
diff --git a/...icy/experimental-features/resources/permissions-policy-focus-without-user-activation.html b/...icy/experimental-features/resources/permissions-policy-focus-without-user-activation.html
@@ -0,0 +1,11 @@
+<!doctype html>
+<script>
+  'use strict';
+  function post_result(enabled) {
+    parent.postMessage({ type: 'availability-result', enabled }, "*");
+  }
+
+  window.onload = function () {
+    post_result(document.featurePolicy.allowedFeatures().includes("focus-without-user-activation"));
+  }
+</script>