Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useRenderButton() needs to accept width as number #4

Closed
ryann3588 opened this issue Jul 28, 2023 · 2 comments
Closed

useRenderButton() needs to accept width as number #4

ryann3588 opened this issue Jul 28, 2023 · 2 comments

Comments

@ryann3588
Copy link

ryann3588 commented Jul 28, 2023 •
edited
Loading

Seems like there was a change maybe 7/27 or 7/28 in the client code that now only accepts a number value for the width property to render a button vs a string. It doesn't render the button if you pass in a string value for width.
@ryann3588 ryann3588 changed the title useRencerButton needs to accept width as number useRenderButton() needs to accept width as number Jul 28, 2023
@i7N3
Copy link
Owner

i7N3 commented Jul 28, 2023

i7N3 added a commit that referenced this issue Jul 28, 2023
@i7N3
fix(src/types/index.ts): make GsiButtonConfiguration width number ins…
8285356 
…tead of string

BREAKING CHANGE: Update width of GsiButtonConfiguration

#4
@i7N3 i7N3 closed this as completed Jul 28, 2023
@ryann3588
Copy link
Author

Thanks for the quick response. I was getting a work around in place when I noticed you updated the package. Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@i7N3 @ryann3588