Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First things first. Welcome to the repo and thank you for submitting you Pull Request!
What you see now is a merge request template. Please remove these two paragraphs and fill in the sections below.
Writing the merge request description helps to share your code faster)
TL;DR
Please explain in one line what is this merge request about
Proof
(before we let the code in, we would like to know it works. You already tested the change so why not document it and show the others as well?
Examples: picture of the Networks tab showing the requests, animated gif, short video).
Merge request checklist
Please check if your merge request fulfills the following requirements:
yarn build
) was run locally and any changes were pushed for both API and clientsyarn api:dev
) runs locally and any fixes were made for failurescd clients/admin && yarn start
) runs locally and any fixes were made for failuresMerge request type
Before this merge request
(describe what was the code state before the MR and what is the current behavior.
Examples: The
/products
API client was missing and is needed for further development)How you fixed what was wrong
(this is the most important part of the MR description.
We already know what was wrong and if we read the issue connected we know where you want to get.
Looking at the code we will also know what you wrote. So please explain why you did it this way.
Examples: I decided to keep the list of the blembas in the store as we use it on more occasions in the application.)