Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blockscout v5 refs #161

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Conversation

gfournieriExec
Copy link
Contributor

No description provided.

@gfournieriExec gfournieriExec requested a review from a team November 21, 2024 13:05
@gfournieriExec gfournieriExec self-assigned this Nov 21, 2024
@@ -45,13 +45,6 @@ IexecPocoAccessorsDelegate: 0xa1d371eF7bf36e89Db41276543ACf91Ec50Dd261 // https:

0b. Verify contracts

- Blockscout v5
```
BLOCKSCOUT_VERSION=v5 npx hardhat run ./scripts/sponsoring/verify.ts --network bellecour
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might remove sponsoring/verify.ts in the future, maybe we should keep it for now yes (?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep it as a second option and specify that it works with v5. We can remove BLOCKSCOUT_VERSION=v5.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept it

@gfournieriExec gfournieriExec merged commit e17654d into develop Nov 25, 2024
1 check passed
@gfournieriExec gfournieriExec deleted the fix/update-blockscout-url branch November 25, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants