Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge Truffle leftovers part 1 - migrations/ and scripts/ #180

Merged
merged 8 commits into from
Jan 17, 2025

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Jan 16, 2025

No description provided.

@zguesmi zguesmi self-assigned this Jan 16, 2025
@zguesmi zguesmi marked this pull request as ready for review January 16, 2025 12:13
@zguesmi zguesmi mentioned this pull request Jan 16, 2025
Copy link
Member

@jeremyjams jeremyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@@ -58,6 +60,5 @@ async function resetNetworkAndDeployAllContracts() {
* @returns proxy address.
*/
export const loadHardhatFixtureDeployment = async () => {
console.log('Running hardhat-fixture');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (1470213) to head (ae63153).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #180   +/-   ##
========================================
  Coverage    84.50%   84.50%           
========================================
  Files           35       35           
  Lines         1084     1084           
  Branches       221      221           
========================================
  Hits           916      916           
  Misses         168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zguesmi zguesmi merged commit 5cc4739 into develop Jan 17, 2025
4 checks passed
@zguesmi zguesmi deleted the feature/truffle-purging-part1 branch January 17, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants