Purge Truffle leftovers part 2 - test/ and utils
#181
Merged
+93
−349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #181 +/- ##
========================================
Coverage 84.50% 84.50%
========================================
Files 35 35
Lines 1084 1084
Branches 221 221
========================================
Hits 916 916
Misses 168 168 ☔ View full report in Codecov by Sentry. |
| @@ -19,8 +20,8 @@ import { | |||
| OwnableMock, | |||
| OwnableMock__factory, | |||
| } from '../../../typechain'; | |||
| import { IexecPoco1 } from '../../../typechain/contracts/modules/interfaces/IexecPoco1.v8.sol'; | |||
| import { IexecPoco1__factory } from '../../../typechain/factories/contracts/modules/interfaces/IexecPoco1.v8.sol'; | |||
| import { IexecPoco1 } from '../../../typechain/contracts/modules/interfaces/IexecPoco1.v8.sol/IexecPoco1'; | |||
There was a problem hiding this comment.
what does it change ?
There was a problem hiding this comment.
Maybe:
import {
ERC1271Mock,
ERC1271Mock__factory,
IERC721__factory,
IexecInterfaceNative,
IexecInterfaceNative__factory,
IexecLibOrders_v5,
IexecPoco1,
IexecPoco1__factory,
IexecPocoAccessors,
IexecPocoAccessors__factory,
OwnableMock,
OwnableMock__factory,
} from '../../../typechain';
There was a problem hiding this comment.
Not sure to understand, here we need the v8 version of the contract IexecPoco1.v8.sol. It cannot be imported directly from the typechain default index.
gfournieriExec
approved these changes
Jan 17, 2025
Co-authored-by: gfournieriExec <[email protected]>
Le-Caignec
approved these changes
Jan 17, 2025
|
|
||
| export function BN2Address(bignumber: BigNumber) { | ||
| const lowercaseAddress = ethers.utils.hexZeroPad(bignumber.toHexString(), 20); | ||
| return ethers.utils.getAddress(lowercaseAddress); |
There was a problem hiding this comment.
utils module disappear in the last version of ethers (v6). We are already on a hold version of hardhat 😵💫
There was a problem hiding this comment.
Yes, the migration is made of different stages :)
jeremyjams
approved these changes
Jan 17, 2025
| @@ -19,8 +20,8 @@ import { | |||
| OwnableMock, | |||
| OwnableMock__factory, | |||
| } from '../../../typechain'; | |||
| import { IexecPoco1 } from '../../../typechain/contracts/modules/interfaces/IexecPoco1.v8.sol'; | |||
| import { IexecPoco1__factory } from '../../../typechain/factories/contracts/modules/interfaces/IexecPoco1.v8.sol'; | |||
| import { IexecPoco1 } from '../../../typechain/contracts/modules/interfaces/IexecPoco1.v8.sol/IexecPoco1'; | |||
There was a problem hiding this comment.
Maybe:
import {
ERC1271Mock,
ERC1271Mock__factory,
IERC721__factory,
IexecInterfaceNative,
IexecInterfaceNative__factory,
IexecLibOrders_v5,
IexecPoco1,
IexecPoco1__factory,
IexecPocoAccessors,
IexecPocoAccessors__factory,
OwnableMock,
OwnableMock__factory,
} from '../../../typechain';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.