Support F@ST F5359 device registration #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copini
force-pushed
the
feature/alternative_device_info
branch
from
6c288e2 to
4057858
Compare
|
Thanks @copini! I haven't had time to have a good look at this, however I would prefer indeed to update the |
|
Understood, I might submit a PR there when I have some time to spend on this again 😉 Closing this one. |
|
@copini someone is already working on this :-) -> iMicknl/python-sagemcom-api#108. I hope to merge the first parts early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #18 and (partially) fixes #19 by not relying on
get_device_info()(which does not work for this device).Perhaps update
get_device_info()in python-sagemcom-api to support this device is a better approach? 🤷