Add Simplified Chinese language to the configurator #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks! You can verify it with the next nightly build. We will also need help to keep it up to date in the future. |
I'll keep an eye on it. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glad to see multilingual support added to the 8.0.0-RC1 program. Since INAV configurator has only been available in English for a long time, but there are a lot of Chinese players using INAV, and the English version of the configurator is very inconvenient to use. Therefore, starting from the 4.0 version in 2022, I continue to produce the Chinese version of the INAV configurator for Chinese players, and the total number of downloads distributed by various platforms is expected to reach more than 20,000 people. To prove that there is a very large group of players using INAV in China, this is the download data of some platforms:
When making the Chinese version of the INAV program, I found that there were many strings that had not been localized, and I had to manually modify these characters to Chinese every time a new version was released. I then submitted three PRS to add these strings to the localization file. At that time, I thought about submitting the Chinese localization file to PR, but because the INAV configurator was forced to select the language version according to the computer system language, which could not be manually modified, I did not have the ability to add the function of manually switching the language to the configurator for the time being. After communicating with the developer, I did not submit PR, but continued to make the Chinese version of the configurator to distribute to players.
Now someone has finally added the language switching function, thank you for his contribution! I think it's time to end the manual production of Chinese INAV configurator and let the official project also add Chinese language support!
Although the Chinese language review is a bit cumbersome and may not be merged as quickly, at least the work of enabling the configurator to support Chinese language is a big step forward.