We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mavlink ATTITUDE message reports yaw in [0..2*PI] range. Message specification says it should be [-PI...PI].
ATTITUDE
yaw
[0..2*PI]
[-PI...PI]
to_json()
PI
{"mavpackettype": "ATTITUDE", "time_boot_ms": 39887824, "roll": -0.01745329238474369, "pitch": -0.04014257341623306, "yaw": 4.0543999671936035, "rollspeed": 0.0, "pitchspeed": 0.0, "yawspeed": 0.0}
Reported yaw value between [-PI...PI].
inav/src/main/telemetry/mavlink.c
Line 596 in c892036
DECIDEGREES_TO_RADIANS((attitude.values.yaw > 1800) ? -(3600-attitude.values.yaw) : attitude.values.yaw),
I can fix this and submit merge request. Before that I just want to confirm if this is not a "feature" driven by specific reasons.
The text was updated successfully, but these errors were encountered:
871d4f3
No branches or pull requests
Current Behavior
Mavlink
ATTITUDE
message reportsyaw
in[0..2*PI]
range. Message specification says it should be[-PI...PI]
.Steps to Reproduce
to_json()
)yaw
is larger thanPI
:{"mavpackettype": "ATTITUDE", "time_boot_ms": 39887824, "roll": -0.01745329238474369, "pitch": -0.04014257341623306, "yaw": 4.0543999671936035, "rollspeed": 0.0, "pitchspeed": 0.0, "yawspeed": 0.0}
Expected behavior
Reported
yaw
value between[-PI...PI]
.Suggested solution(s)
inav/src/main/telemetry/mavlink.c
Line 596 in c892036
Change to
Additional context
I can fix this and submit merge request. Before that I just want to confirm if this is not a "feature" driven by specific reasons.
The text was updated successfully, but these errors were encountered: