-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC via MAVLink & MAVLink V2 Support #6738
Conversation
Hm, looks like I need to make sure docs are updated. Do I just need to run |
You need to run |
@avsaase Thank you very much! |
Looks like this consumes nearly 41k extra flash on F411.... yikes. I'll have to optimize it a lot. Seems like most of it is coming from the MAVLink library which should get mostly optimized away by the compiler... Obviously not... |
Hey, maybe, just by the way, You could consider addressing #6577 in Your commits? :) |
@harry1453 any chance of optimization of the MAVLink in the next few weeks? I have a feeling F411 are not the only ones that are failing and the same happens with F722. |
@DzikuVx Yes, I'll get on to this as soon as I can. My current idea for optimization is to try and slim down the MAVLink library and remove all the messages that we aren't using. I don't know why but it appears that the compiler isn't optimizing them out when it should. Failing that we might, as you said, need a compiler switch for MAVLink V2... but that would make things very complicated as the libraries are different and every library call would need the compiler switch. @nathanjel I'll take a look! |
Turns out the MAVLink library declares every single function as Target MATEKF411SE |
@harry1453 please resolve conflicts and let's merge it. Thanks a lot! |
# Conflicts: # docs/Settings.md # src/main/fc/settings.yaml # src/main/target/common.h # src/main/telemetry/telemetry.c
The time has come, let's merge it! Thanks a lot @harry1453 |
Closes #6571
This PR
mavlink_version
to switch back to MAVLink V1 for backwards compatibility (defaults to V2)