Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate waypoints messages in the OSD/Hud #6556

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Remove duplicate waypoints messages in the OSD/Hud #6556

merged 1 commit into from
Feb 11, 2021

Conversation

OlivierC-FR
Copy link
Contributor

... since it's now displayed in the system message ("TO WP 1/4")

... since it's now displayed in the system message ("TO WP 1/4")
@OlivierC-FR OlivierC-FR changed the title Remove duplicate WP message in the OSD/Hud Remove duplicate waypoints messages in the OSD/Hud Feb 2, 2021
@breadoven
Copy link
Collaborator

There is the possibility that you have an OSD screen with HUD but no system messages field in which case you might want to keep the HUD WP countdown. Perhaps a separate "To WP" OSD field is required, put it where you like.

Also, the messages are slightly different, the HUD one actually shows WPs completed rather than the one you're heading to. Not sure if this was intentional or a mistake, perhaps a mistake given the code is dealing with next WPs.

@OlivierC-FR
Copy link
Contributor Author

OlivierC-FR commented Feb 2, 2021

There is the possibility that you have an OSD screen with HUD but no system messages field in which case you might want to keep the HUD WP countdown. Perhaps a separate "To WP" OSD field is required, put it where you like.

Also, the messages are slightly different, the HUD one actually shows WPs completed rather than the one you're heading to. Not sure if this was intentional or a mistake, perhaps a mistake given the code is dealing with next WPs.

Interesting, I didn't think of the case where the user would disable the system message, but that's highly uncommon IMHO.
The fact one shows WP and the other WP+1, was not intentional nor planned, it's just I made the display of the WP in the hud first, and then someone else added the WPs in the message system line later. It makes more sense to have it in the message system I think, that's less clutter on the screen. Or it could be an option to be displayed on/off in the hud. But there's already so many options in INAV, unsure one more is a good idea :[

@DzikuVx DzikuVx added this to the 2.7 milestone Feb 3, 2021
@DzikuVx DzikuVx merged commit 251e9f1 into iNavFlight:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants