[FEATURE] Prearm #6562
Merged
[FEATURE] Prearm #6562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalentity
requested changes
Feb 3, 2021
There was a problem hiding this comment.
Looks good in general. Just a few things:
- Please remove the breaking separation into
armingFlagsandarmingDisabledFlags. Configurator and other external peripherals depend on that bitfield. - I don't fully undestand the logic behind the additional
ARMED_WITH_PREARMflag. Can't we process the prearm bit always? - Optimization regarding checking for "prearm" mode being present. We shouldn't be evaluating the whole aux table every cycle.
|
Please do not break established APIs; they are used by multiple 3rd party applications. |
|
Thanks for the review! In response to the review:
|
digitalentity
requested changes
Feb 3, 2021
digitalentity
approved these changes
Feb 4, 2021
stronnag
added
the
Release Notes
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a Prearm (#5595). It adds a new mode switch
which will need a relevant configurator PR.I also took the opportunity to fix this FIXME by separating out thearmingFlagsenum into Arming Flags (flags relating to the current arming) and Arming Disable Flags (flags that prevent arming). This forms the bulk of this PR as I gave the macros clearer names.