Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set failsafe procedure from OSD #6727

Merged

Conversation

kernel-machine
Copy link
Contributor

When i fly in an open space i prefer to have the failsafe procedure with RTH, but when i fly in a bando that have some parts in which the sky is visible and other parts in which is covered, i prefer to have the FS procedure to drop, even if i have a valid GPS fix, maybe the FS could enter when the quad is under something and i risk to hit when the quad gain altitude.

With this pull request i will capable to set the failsafe procedure from the OSD that is a quickly way rather than connect the quad to the configurator or to speedybee

@rts18
Copy link

rts18 commented Mar 20, 2021

@kernel-machine Cool idea.
Would you be open to another addition?
Disabling GPS at the time of FS will put the quad into Nav Landing mode. It will still drift with the wind, but it may prevent it from crashing down on the concrete from height.

@kernel-machine
Copy link
Contributor Author

@rts18 i don't understand well your idea. With this pull request you are able to choose all failsafe procedures available on iNav via OSD, so you can also set the landing mode procedure in case of failsafe

@rts18
Copy link

rts18 commented Mar 20, 2021

@kernel-machine What I was suggesting is not Land mode procedure from the configurator failsafe tab. That is timer-throttle based landing.
I was suggesting Nav Landing mode. Which puts the quad in to a barometer based landing cycle. Just the same as occurs when the quad returns to home and auto lands and is disarmed by the Nav system.

If no GPS is available at the moment you switch to RTH the quad will start emergency descent at 5 m/s (default value of nav_emerg_landing_speed setting. This is intended as a safest way to prevent fly-aways.

@kernel-machine
Copy link
Contributor Author

@rts18 ok, i got it.
I don't believe to implement it for the moment, I'm not sure that there are a lot of people that require this feature and it's not a quickly work

@rts18
Copy link

rts18 commented Mar 20, 2021

@rts18 ok, i got it.
I don't believe to implement it for the moment, I'm not sure that there are a lot of people that require this feature and it's not a quickly work

That's cool. I understand it was not totally in line with this PR.

It was more about, there being another means of saving the quad when flying at bando's.
I have flown behind high buildings before.
If a FS occurs at that time, I don't want RTH. And Drop from 50meters on the concrete isn't good either.
Nav land was just another option.

@harryjph
Copy link
Contributor

@rts18 I think you're talking about adding NAV LANDING as a failsafe option as opposed to the current "dumb" landing, which is outside of the scope of this PR. Maybe you should open it as a feature request issue?

@rts18
Copy link

rts18 commented Mar 25, 2021

I think you're talking about adding NAV LANDING as a failsafe option as opposed to the current "dumb" landing, which is outside of the scope of this PR. Maybe you should open it as a feature request issue?

@harry1453 That's exactly it Harry.
I don't mind opening a feature request. But writing its implementation is beyond me. Are you offering ? :)

@DzikuVx DzikuVx added this to the 2.7 milestone Mar 29, 2021
@DzikuVx DzikuVx merged commit e260118 into iNavFlight:master Mar 31, 2021
@kernel-machine kernel-machine deleted the km_failsafe_procedure_from_osd branch March 31, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants