Allow passing of custom arguments to urllib Request object #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=========================================
- Coverage 72.54% 71.05% -1.5%
=========================================
Files 5 5
Lines 641 646 +5
=========================================
- Hits 465 459 -6
- Misses 176 187 +11
Continue to review full report at Codecov.
|
iTaybb
requested changes
Jul 21, 2019
pySmartDL/pySmartDL.py
Outdated
| @@ -75,14 +77,21 @@ class SmartDL: | |||
| * If no path is provided, `%TEMP%/pySmartDL/` will be used. | |||
| ''' | |||
|
|
|||
| def __init__(self, urls, dest=None, progress_bar=True, fix_urls=True, threads=5, timeout=5, logger=None, connect_default_logger=False): | |||
| def __init__(self, urls, dest=None, progress_bar=True, fix_urls=True, threads=5, timeout=5, logger=None, connect_default_logger=False, requestArgs=None): | |||
There was a problem hiding this comment.
- this is user-facing API and therefore requestArgs should become request_args
- I feel like it should come after "fix_urls" or something, and not at the end of the constructor.
- The place must be in sync with the docs
There was a problem hiding this comment.
1 and 3 have been fixed. As for 2, I put it at the end as to not break any code that currrently uses positional arguments. I can change it if you'd like though.
|
Thanks |
iTaybb
added a commit
that referenced
this pull request
Jul 26, 2019
- fixes over MR #34 - get_json method for SmartDL - better logging syntax - added tests - change test files host from hetzner.de to ovh
iTaybb
added a commit
that referenced
this pull request
Jul 26, 2019
- fixes over MR #34 - get_json method for SmartDL - better logging syntax - added tests - change test files host from hetzner.de to ovh
iTaybb
added a commit
that referenced
this pull request
Jul 26, 2019
- fixes over MR #34 - get_json method for SmartDL - better logging syntax - added tests - change test files host from hetzner.de to ovh
iTaybb
added a commit
that referenced
this pull request
Jul 26, 2019
- fixes over MR #34 - get_json method for SmartDL - better logging syntax - added tests - updated user agents - change test files host from hetzner.de to ovh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for more granular control of headers, proxies, and anything else that urllib provides an option for without having to implement the functionality in pySmartDL. Closes #33