-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
stories/core/Table.stories.tsx
Outdated
{...args} | ||
/> | ||
<Tooltip | ||
reference={rowRefMap.current[hoveredRowIndex]} | ||
content={`Hovered over ${data[hoveredRowIndex].name}.`} | ||
placement='bottom' | ||
followCursor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slipped in story update from the discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So are you going to undo it? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too much work, I'll just leave it here and hope nobody sees it 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least add initial
. It is considered outdated UX practice for tooltip to follow cursor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a link for this guideline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check our standards.
The guideline was updated in BWC standards first:
The tooltip should be anchored to the item that is being hovered and should not follow the cursor as it moves.
And then refined in iTwinUI standards:
It is anchored to the hovered item and fades out when the cursor moves away from the item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed for now.
Closes #84
column.resizeWidth
that I got from ref.minWidth
andmaxWidth
therefore you can't resize past those.flex-grow
andflex-shrink
, then getting new widths and making columns static again.useResizeColumns
hook is taken fromreact-table
and I make it work withownerDocument
also cleaned up code a bit and made it to resize sibling columns.Checklist