-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test image results #864
Comments
If all tests are wrapped consistently via |
I would like to reduce non-component HTML as well. Meaning replace |
* Clicking the "Select all" checkbox when it is in the indeterminate state now unselects all rows. * Filtered rows can now be deselected with the "Select all" checkbox.
Tile focus screenshots does not include focus style (images are cropped too tight) |
All test images should be reviewed with the goal of:
<section>
or a component directly via ID name, excluding the page titles,<hr>
s, & theme switcher button.<section>
should be scoped. Some places this may make sense (table sizes), other places it might not (badges). Use your best judgement.:hover
&:focus
within the same test image.viewports: [{ width: 800, height: 600 }]
to keep images narrow when possible. These are good default values, but feel free to adjust as needed.Components to review
The text was updated successfully, but these errors were encountered: