Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test image results #864

Open
8 of 49 tasks
Tracked by #1571
FlyersPh9 opened this issue Dec 19, 2022 · 3 comments · Fixed by #866, #867 or #871
Open
8 of 49 tasks
Tracked by #1571

Improve test image results #864

FlyersPh9 opened this issue Dec 19, 2022 · 3 comments · Fixed by #866, #867 or #871
Labels
good first issue Good for newcomers maintenance Related to development or technical debt or chores

Comments

@FlyersPh9
Copy link
Collaborator

FlyersPh9 commented Dec 19, 2022

All test images should be reviewed with the goal of:

  • Tests should target a <section> or a component directly via ID name, excluding the page titles, <hr>s, & theme switcher button.
  • <section> should be scoped. Some places this may make sense (table sizes), other places it might not (badges). Use your best judgement.
  • If possible, test for :hover & :focus within the same test image.
  • Set viewports: [{ width: 800, height: 600 }] to keep images narrow when possible. These are good default values, but feel free to adjust as needed.

Components to review

  • alert
  • anchor: Nothing to change
  • avatar
  • badge
  • blockquote
  • breadcrumbs
  • button
  • carousel
  • checkbox
  • code
  • color-picker
  • color
  • column-filter
  • date-picker
  • dialog
  • expandable-block
  • fieldset
  • file-upload
  • footer
  • header
  • iModel-loader
  • icon
  • information-panel
  • input
  • keyboard
  • location-marker
  • menu
  • non-ideal-state
  • progress-indicator
  • radio-tile
  • radio
  • select
  • side-navigation
  • skip-to-content
  • slider
  • stepper
  • surface
  • table
  • tabs
  • tag
  • textarea
  • tile
  • time-picker
  • toast
  • toggle-switch
  • tooltip
  • tree
  • typography
  • workflow-diagram
@FlyersPh9 FlyersPh9 added the maintenance Related to development or technical debt or chores label Dec 19, 2022
@FlyersPh9
Copy link
Collaborator Author

If all tests are wrapped consistently via <section>, we might be able to apply padding to them so our test images aren't cropped right to the edge of the component. This would be useful for confirming things like drop shadow are displaying correctly.

@FlyersPh9
Copy link
Collaborator Author

I would like to reduce non-component HTML as well. Meaning replace <br /> with gap applied on the <section> wrapping the components.

This was linked to pull requests Dec 19, 2022
mayank99 pushed a commit that referenced this issue Dec 19, 2022
* Clicking the "Select all" checkbox when it is in the indeterminate state now unselects all rows.

* Filtered rows can now be deselected with the "Select all" checkbox.
@FlyersPh9 FlyersPh9 self-assigned this Dec 20, 2022
@FlyersPh9 FlyersPh9 linked a pull request Dec 20, 2022 that will close this issue
@FlyersPh9 FlyersPh9 reopened this Dec 29, 2022
@FlyersPh9 FlyersPh9 reopened this Dec 29, 2022
@FlyersPh9 FlyersPh9 reopened this Dec 29, 2022
@gretanausedaite
Copy link
Contributor

Tile focus screenshots does not include focus style (images are cropped too tight)

@FlyersPh9 FlyersPh9 removed their assignment Mar 20, 2023
@mayank99 mayank99 mentioned this issue Sep 21, 2023
18 tasks
@siddhantrawal siddhantrawal self-assigned this Jan 8, 2024
@FlyersPh9 FlyersPh9 added the good first issue Good for newcomers label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers maintenance Related to development or technical debt or chores
Projects
None yet
3 participants