Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay component #924

Closed
veekeys opened this issue Oct 5, 2021 · 3 comments · Fixed by #1328
Closed

Overlay component #924

veekeys opened this issue Oct 5, 2021 · 3 comments · Fixed by #1328
Assignees
@marashad001
Labels
enhancement New feature or request good first issue Good for newcomers react Needs change in react package

Comments

@veekeys
Copy link
Member

veekeys commented Oct 5, 2021

We have css for it, lets add a react component.
@veekeys veekeys added the enhancement New feature or request label Oct 5, 2021
@mayank99
Copy link
Contributor

mayank99 commented Oct 5, 2021

Can you add a link or screenshot? Not sure what an "overlay" component entails.

@veekeys
Copy link
Member Author

veekeys commented Oct 5, 2021

Can you add a link or screenshot? Not sure what an "overlay" component entails.

https://github.com/iTwin/iTwinUI/blob/main/src/progress-indicator/overlay.scss

@mayank99 mayank99 transferred this issue from iTwin/iTwinUI-react Dec 22, 2022
@gretanausedaite gretanausedaite added the react Needs change in react package label Dec 23, 2022
@mayank99 mayank99 added the good first issue Good for newcomers label Feb 8, 2023
@mayank99 mayank99 mentioned this issue May 30, 2023
Closed
@mayank99
Copy link
Contributor

Adding updated links and screenshot.

Source code: https://github.com/iTwin/iTwinUI/blob/62a1eef90fd32932c327033ada2a956191025ce7/packages/itwinui-css/src/progress-indicator/overlay.scss

Preview (scroll to bottom): https://itwin.github.io/iTwinUI/dev/css/progress-indicator.html

@marashad001 marashad001 mentioned this issue Jun 6, 2023
Merged
@mayank99 mayank99 linked a pull request Jun 7, 2023 that will close this issue
feat(Overlay): new React Overlay component #1328
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marashad001 marashad001

Labels
enhancement New feature or request good first issue Good for newcomers react Needs change in react package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Overlay): new React Overlay component iTwin/iTwinUI
4 participants
@mayank99 @veekeys @gretanausedaite @marashad001