Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog: positioning #1313

Closed
gretanausedaite opened this issue May 30, 2023 · 2 comments · Fixed by #1323
Closed

Dialog: positioning #1313

gretanausedaite opened this issue May 30, 2023 · 2 comments · Fixed by #1323
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gretanausedaite
Copy link
Contributor

gretanausedaite commented May 30, 2023

Feature

Positions for Dialog:

Examples

An optional placement prop can be added to Dialog.

<Dialog placement='top-left'>
<Dialog placement='bottom-left'>
<Dialog placement='top-right'>
<Dialog placement='bottom-right'>

The prop will likely need to be stored in DialogContext (by Dialog) and then used inside DialogMain to set the data-iui-placement attribute.

@gretanausedaite gretanausedaite added enhancement New feature or request good first issue Good for newcomers labels May 30, 2023
@coderr01
Copy link

@gretanausedaite i would like to contribute on the issue

@mayank99
Copy link
Contributor

mayank99 commented May 30, 2023

Hey @coderr01, thanks for your interest, but this issue was actually created for @marashad001 (who also wrote the original CSS for it in #679).

If you are still interested in contributing to iTwinUI, may I recommend #924 or #129? Or we can find you a different task depending on your skills and interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants