website: ButtonGroup #1162
Merged
website: ButtonGroup #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gretanausedaite
requested review from
a team,
FlyersPh9 and
adamhock
and removed request for
a team
68 tasks
FlyersPh9
reviewed
Mar 28, 2023
Co-authored-by: Jon Graft <[email protected]>
adamhock
reviewed
Mar 29, 2023
Co-authored-by: adamhock <[email protected]>
Co-authored-by: adamhock <[email protected]>
Co-authored-by: adamhock <[email protected]>
Co-authored-by: adamhock <[email protected]>
FlyersPh9
reviewed
Mar 30, 2023
FlyersPh9
reviewed
Mar 30, 2023
FlyersPh9
reviewed
Mar 30, 2023
FlyersPh9
reviewed
Mar 30, 2023
|
|
||
| ### Overflow | ||
|
|
||
| If there is not enough space to display all of the buttons, the buttons can truncate into an overflow menu. |
There was a problem hiding this comment.
Does it make sense to link the word menu to the menu component?
There was a problem hiding this comment.
Added a link to dropdown menu button and updated overflow sample to be more simple
gretanausedaite
force-pushed
the
greta/button-group
branch
from
60a3273 to
a05c346
Compare
FlyersPh9
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated ButtonGroup documentation page
Solves ButtonGroup part of #961
Testing
N/A
Docs
N/A