Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Update radio tiles documentation & demos #1179

Merged
merged 28 commits into from
May 2, 2023

Conversation

idakukimiya
Copy link
Contributor

  • Added description for radio tiles
  • Remove placeholder, line 12 and 17

@idakukimiya idakukimiya self-assigned this Mar 31, 2023
@idakukimiya idakukimiya requested a review from a team as a code owner March 31, 2023 15:35
@idakukimiya idakukimiya requested review from a team, gretanausedaite and elephantcatdog and removed request for a team March 31, 2023 15:35
@idakukimiya idakukimiya marked this pull request as draft March 31, 2023 15:35
@FlyersPh9 FlyersPh9 changed the title website: Update checkbox documentation & demos website: Update radio tiles documentation & demos Mar 31, 2023
@FlyersPh9 FlyersPh9 added the documentation Improvements or additions to documentation label Mar 31, 2023
@idakukimiya idakukimiya marked this pull request as ready for review April 3, 2023 13:55
@mayank99
Copy link
Contributor

mayank99 commented Apr 4, 2023

@idakukimiya Why did you remove all assigned reviewers if this PR is ready for review?

@idakukimiya
Copy link
Contributor Author

@mayank99 The initial push was a draft. I was unsure if I was to take or leave the reviewer since I was working with Jon on the documentation.

@mayank99
Copy link
Contributor

mayank99 commented Apr 4, 2023

If it is ready for review now (i.e. no longer draft), then you should add the reviewers back.

apps/website/src/examples/RadioTile.color.tsx Outdated Show resolved Hide resolved
apps/website/src/pages/docs/radiotile.mdx Outdated Show resolved Hide resolved
apps/website/src/pages/docs/radiotile.mdx Outdated Show resolved Hide resolved
apps/website/src/pages/docs/radiotile.mdx Outdated Show resolved Hide resolved
<LiveExample src='RadioTile.main.tsx'>
<AllExamples.RadioTileMainExample client:load />
</LiveExample>

## Usage

A series of selectable tile components that behave like radio button. You may include icons to help make each tile more identifiable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the line "A series of selectable tile components that behave like radio button." should go in the description on line 3. Or add something else to the description on line 3 because it's missing one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be updated.

apps/website/src/pages/docs/radiotile.mdx Outdated Show resolved Hide resolved

The example below is the condensed version of the radio tiles. They contain only a label and an icon (the icon is optional but recommended is using condensed). If you do not need descriptive text, go with the condensed radio tiles to save space.

Disabled radio tiles can coexit with active tile. A selected tile can also take on the disabled state.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"tiles can coexit with" -> "tiles can coexist with"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be updated.

@idakukimiya idakukimiya added this pull request to the merge queue May 2, 2023
Merged via the queue into main with commit 0d14f8f May 2, 2023
@idakukimiya idakukimiya deleted the ida-documentation-radio-tile branch May 2, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants