-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website: Update radio tiles documentation & demos #1179
Conversation
idakukimiya
commented
Mar 31, 2023
- Added description for radio tiles
- Remove placeholder, line 12 and 17
Co-authored-by: Jon Graft <[email protected]>
…winUI into ida-documentation-radio
Co-authored-by: Jon Graft <[email protected]>
Co-authored-by: Jon Graft <[email protected]>
@idakukimiya Why did you remove all assigned reviewers if this PR is ready for review? |
@mayank99 The initial push was a draft. I was unsure if I was to take or leave the reviewer since I was working with Jon on the documentation. |
If it is ready for review now (i.e. no longer draft), then you should add the reviewers back. |
…in/iTwinUI into ida-documentation-radio-tile
<LiveExample src='RadioTile.main.tsx'> | ||
<AllExamples.RadioTileMainExample client:load /> | ||
</LiveExample> | ||
|
||
## Usage | ||
|
||
A series of selectable tile components that behave like radio button. You may include icons to help make each tile more identifiable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the line "A series of selectable tile components that behave like radio button." should go in the description
on line 3. Or add something else to the description on line 3 because it's missing one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs to be updated.
|
||
The example below is the condensed version of the radio tiles. They contain only a label and an icon (the icon is optional but recommended is using condensed). If you do not need descriptive text, go with the condensed radio tiles to save space. | ||
|
||
Disabled radio tiles can coexit with active tile. A selected tile can also take on the disabled state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tiles can coexit with" -> "tiles can coexist with"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs to be updated.
Co-authored-by: Jon Graft <[email protected]>
…in/iTwinUI into ida-documentation-radio-tile