website: Update tooltip documentation & demos #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
idakukimiya
commented
Apr 12, 2023
idakukimiya
commented
- Update documentation
- Remove placeholder
idakukimiya
requested review from
a team,
FlyersPh9 and
LostABike
and removed request for
a team
68 tasks
LostABike
reviewed
Apr 13, 2023
LostABike
reviewed
Apr 13, 2023
gretanausedaite
requested review from
gretanausedaite
and removed request for
FlyersPh9
…iTwinUI into ida-documentation-tooltip
LostABike
approved these changes
Apr 20, 2023
LostABike
reviewed
Apr 20, 2023
LostABike
reviewed
Apr 20, 2023
Comment on lines
38
to
42
| <LiveExample src='Slider.tooltipnone.tsx'> | ||
| <AllExamples.SliderTooltipNoneExample client:load /> | ||
| </LiveExample> | ||
|
|
||
| Tooltips are enabled by default but can be turned off. |
There was a problem hiding this comment.
I think you meant to group the demo for "tooltip in Slider" and "tooltips can be disabled" into one example here but that would be a little confusing. Maybe we can separate it? So normal slider with tooltip belong to the first group of examples. And then another slider without tooltip to demonstrate that tooltips can be disabled. I'm not too sure, maybe we can have a second opinion on this.
There was a problem hiding this comment.
Personally I think these stepper and slider examples don't even belong on this page. Just links to those specific examples in their own pages should be enough.
LostABike
reviewed
Apr 20, 2023
Co-authored-by: Greta <[email protected]>
LostABike
reviewed
May 1, 2023
LostABike
reviewed
May 4, 2023
Co-authored-by: LostABike <[email protected]>
Co-authored-by: LostABike <[email protected]>
gretanausedaite
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.