Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown API children improvement #1403

Merged
merged 6 commits into from
Jul 17, 2023
Merged

Dropdown API children improvement #1403

merged 6 commits into from
Jul 17, 2023

Conversation

LostABike
Copy link
Contributor

@LostABike LostABike commented Jul 11, 2023 •
edited
Loading

Changes

  • Accept additional type of JSX.Element[] and JSX.Element for menuItems prop

Testing

  • Added unit tests

Docs

@gretanausedaite gretanausedaite added this to the React 3.0 milestone Jul 12, 2023
@LostABike LostABike marked this pull request as ready for review July 13, 2023 21:31
@LostABike LostABike requested review from a team as code owners July 13, 2023 21:31
@LostABike LostABike requested review from mayank99 and adamhock and removed request for a team July 13, 2023 21:31
mayank99
mayank99 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@mayank99 mayank99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. i like that it's backwards compatible!

don't forget to add changeset and unit test.

adamhock
adamhock approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@adamhock adamhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, but other than that it looks good to go

packages/itwinui-react/src/core/DropdownMenu/DropdownMenu.tsx Outdated
@@ -44,6 +44,7 @@ export type DropdownMenuProps = {
* Item #3
* </MenuItem>,
* ];
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicky, but I would remove this added line just to keep the changes as concise as possible

@LostABike LostABike added this pull request to the merge queue Jul 17, 2023
Merged via the queue into dev with commit 4cf2c60 Jul 17, 2023
@LostABike LostABike deleted the dropdown-improve branch July 17, 2023 20:06
@imodeljs-admin imodeljs-admin mentioned this pull request Jul 17, 2023
Merged
@gretanausedaite gretanausedaite linked an issue Jul 19, 2023 that may be closed by this pull request
v3: Change DropdownMenu API to be more usable #972
Closed
@imodeljs-admin imodeljs-admin mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayank99 mayank99 mayank99 approved these changes

@adamhock adamhock adamhock approved these changes

Assignees

@LostABike LostABike

Labels
None yet
Projects
None yet
Milestone
React 3.0
Development

Successfully merging this pull request may close these issues.

v3: Change DropdownMenu API to be more usable
4 participants
@LostABike @mayank99 @adamhock @gretanausedaite