Documentation: InputGrid and InputWithDecorations #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gretanausedaite
requested review from
mayank99 and
r100-stack
and removed request for
a team
mayank99
reviewed
Sep 1, 2023
| @@ -17,7 +17,7 @@ import * as AllExamples from 'examples'; | |||
| <AllExamples.InputGroupToggleSwitchExample client:load /> | |||
| </LiveExample> | |||
|
|
|||
| Input group class is a container to enhance an input by adding an icon, text, or a button in front or behind the input field as a "help text". | |||
| Input group is a container to enhance an input by adding an icon, text, or a button in front or behind the input field as a "help text". | |||
There was a problem hiding this comment.
i think input group is only for radio/checkbox/toggle rather than regular inputs, so it might be worth mentioning
There was a problem hiding this comment.
I was not prepared to update InputGroup docs because description is also wrong, just saw a small mistake in text. I can look into it more if you'd like. Or undo this change.
r100-stack
reviewed
Sep 1, 2023
mayank99
approved these changes
Sep 5, 2023
r100-stack
approved these changes
Sep 5, 2023
This is generated automatically. Will not be fixed in this PR. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added docs pages for InputWithDecorations, InputGrid and StatusMessage.
Testing
N/A
Docs
N/A