Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added workspace test #243

Merged
merged 12 commits into from
Sep 13, 2023
Merged

added workspace test #243

merged 12 commits into from
Sep 13, 2023

Conversation

iambumblehead
Copy link
Owner

@iambumblehead iambumblehead commented Sep 11, 2023

closes #235

The new branch uses an updated version of resolvewithplus and should do the following things,

  • when typescript is detected, should resolve moduleIds from things like { "main": "./index.js" }, where "index.ts" should be returned rather than "index.js",
  • when typescript is detected, should resolve moduleIds from things like "./local-file.js" where "./local-file.ts" should be returned rather than "./local-file.js"

@iambumblehead
Copy link
Owner Author

Configuring deeply nested test folders to use local "esmock.js" with "--loader" in both windows and linux test environments is overly difficult. It would be easier to start this feature after the initialize hook is merged #240 so that "--loader" can be removed from these workspace tests.

This was referenced Sep 11, 2023
@iambumblehead
Copy link
Owner Author

@koshic @tpluscode please review

@iambumblehead
Copy link
Owner Author

Merging, as these changes seem relatively low-risk. If issues around typescript resolution are reported, the resolver package could be reverted to the previous version.

@iambumblehead iambumblehead merged commit 0b8888d into master Sep 13, 2023
@iambumblehead iambumblehead deleted the add-workspace-tests branch September 13, 2023 20:06
@iambumblehead
Copy link
Owner Author

feel free to leave retro-active review, these changes are published to [email protected]

@tpluscode
Copy link

Well, most importantly, my project now works without any workarounds. Very nice. Thank you @iambumblehead!

@iambumblehead
Copy link
Owner Author

@tpluscode awesome thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid moduleId in a TypeScript monorepo
3 participants